Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubernetes templates for elastic-agent [templates.d] #6500

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Update kubernetes templates for elastic-agent [templates.d] #6500

merged 1 commit into from
Jan 10, 2025

Conversation

elastic-vault-github-plugin-prod[bot]
Copy link
Contributor

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner January 9, 2025 12:54
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025

This pull request does not have a backport label. Could you fix it @elastic-vault-github-plugin-prod[bot]? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 9, 2025
@swiatekm
Copy link
Contributor

swiatekm commented Jan 9, 2025

This includes changes from both https://github.com/elastic/package-storage-infra/pull/904 and https://github.com/elastic/package-storage-infra/pull/905. After this PR, the template refresh job shouldn't rearrange the input order anymore.

@pkoutsovasilis
Copy link
Contributor

After having a look on this PR I see no issues with it. That said, I believe that we should also make the necessary changes to run the k8s integration tests step of our CI when these files change 🙂

@swiatekm
Copy link
Contributor

swiatekm commented Jan 9, 2025

This PR can wait until #6505 is merged and we can verify that integration tests pass.

swiatekm
swiatekm requested changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait until #6505 is merged and we've rebased on it.

@swiatekm swiatekm force-pushed the update-k8s-templates-20250109125421 branch from 8a248b1 to f26bf0d Compare January 10, 2025 10:30
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@swiatekm swiatekm added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jan 10, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@swiatekm swiatekm merged commit c217be3 into main Jan 10, 2025
14 checks passed
@swiatekm swiatekm deleted the update-k8s-templates-20250109125421 branch January 10, 2025 15:49
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
@elastic-vault-github-plugin-prod @mergify
[automation] Publish kubernetes templates for elastic-agent (#6500)
eacb253 
Co-authored-by: elasticmachine <elasticmachine@elastic.co>
(cherry picked from commit c217be3)
@mergify mergify bot mentioned this pull request Jan 10, 2025
Merged
swiatekm pushed a commit that referenced this pull request Jan 10, 2025
@mergify @elastic-vault-github-plugin-prod
[automation] Publish kubernetes templates for elastic-agent (#6500) (#…
e33ec6c 
…6514)

Co-authored-by: elasticmachine <elasticmachine@elastic.co>
(cherry picked from commit c217be3)

Co-authored-by: elastic-vault-github-plugin-prod[bot] <150874479+elastic-vault-github-plugin-prod[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@pkoutsovasilis pkoutsovasilis pkoutsovasilis approved these changes

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees
No one assigned
Labels
automation backport-8.x Automated backport to the 8.x branch with mergify skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swiatekm @pkoutsovasilis @elasticmachine