[8.17](backport #6184) Avoid unnecessary copies during config generation #6249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove some unnecessary copies when generating component configuration.
The first copy avoided is done because we want to replace the
inputs
key with the rendered inputs. A shallow copy is sufficient for this. I did find and fix a bug in Dict shallow copies while at it.The rest of the copies have to do with applying vars to each AST node. We currently make a copy of each Node we do this for, but that's not necessary, as
Apply
creates a new Node with all the data recursively copied anyway. I've added a test to verify thatApply
actually works this way.Benchstat result vs
main
, using the benchmark from #6180:Why is it important?
More performance is good! More broadly, this is an attempt to incrementally improve the problem from #5991.
Checklist
./changelog/fragments
using the changelog toolRelated issues
This is an automatic backport of pull request #6184 done by [Mergify](https://mergify.com).