-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip versions newer than version under test for upgrade tests #3169
Merged
pchila
merged 1 commit into
elastic:main
from
pchila:limit-upgrades-to-version-older-than-latest
Aug 3, 2023
Merged
Skip versions newer than version under test for upgrade tests #3169
pchila
merged 1 commit into
elastic:main
from
pchila:limit-upgrades-to-version-older-than-latest
Aug 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchila
added
skip-changelog
Testing
backport-v8.9.0
Automated backport with mergify
labels
Aug 2, 2023
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
blakerouse
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
🌐 Coverage report
|
/test |
pierrehilbert
approved these changes
Aug 2, 2023
buildkite test this |
AndersonQ
approved these changes
Aug 3, 2023
/test |
mergify bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
## What does this PR do? This PR filters out versions that too new from agent upgrade integration tests, allowing backport of those test on release branches. This PR needs to backported together with #2955 onto 8.9 branch ## Why is it important? We want to have working upgrade tests with relevant versions also on release branches (cherry picked from commit 3de585e) # Conflicts: # testing/integration/upgrade_test.go
pchila
added a commit
that referenced
this pull request
Aug 4, 2023
This PR filters out versions that too new from agent upgrade integration tests, allowing backport of those test on release branches. This PR needs to backported together with #2955 onto 8.9 branch We want to have working upgrade tests with relevant versions also on release branches
pchila
added a commit
that referenced
this pull request
Aug 4, 2023
… upgrade tests (#3172) This is an automatic backport of pull request #3169 done by [Mergify](https://mergify.com). Co-authored-by: Paolo Chila <paolo.chila@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.9.0
Automated backport with mergify
skip-changelog
Team:Elastic-Agent
Label for the Agent team
Testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR filters out versions that too new from agent upgrade integration tests, allowing backport of those test on release branches.
This PR needs to backported together with #2955 onto 8.9 branch
Why is it important?
We want to have working upgrade tests with relevant versions also on release branches
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragments
using the changelog tool[ ] I have added an integration test or an E2E testAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
Questions to ask yourself