Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip versions newer than version under test for upgrade tests #3169

Merged

Conversation

pchila
Copy link
Member

@pchila pchila commented Aug 2, 2023

What does this PR do?

This PR filters out versions that too new from agent upgrade integration tests, allowing backport of those test on release branches.

This PR needs to backported together with #2955 onto 8.9 branch

Why is it important?

We want to have working upgrade tests with relevant versions also on release branches

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pchila pchila added skip-changelog Testing backport-v8.9.0 Automated backport with mergify labels Aug 2, 2023
@pchila pchila self-assigned this Aug 2, 2023
@pchila pchila requested a review from a team as a code owner August 2, 2023 14:31
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Aug 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-03T05:28:09.600+0000

  • Duration: 28 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 6153
Skipped 31
Total 6184

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 2, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.718% (77/78) 👍
Files 68.248% (187/274) 👍
Classes 66.863% (341/510) 👍
Methods 53.661% (1070/1994) 👍
Lines 39.911% (12251/30696) 👍 0.029
Conditionals 100.0% (0/0) 💚

@pchila
Copy link
Member Author

pchila commented Aug 2, 2023

/test

@pchila
Copy link
Member Author

pchila commented Aug 2, 2023

buildkite test this

@pchila
Copy link
Member Author

pchila commented Aug 3, 2023

/test

@pchila pchila merged commit 3de585e into elastic:main Aug 3, 2023
mergify bot pushed a commit that referenced this pull request Aug 3, 2023
## What does this PR do?

This PR filters out versions that too new from agent upgrade integration
tests, allowing backport of those test on release branches.

This PR needs to backported together with #2955 onto 8.9 branch

## Why is it important?

We want to have working upgrade tests with relevant versions also on
release branches

(cherry picked from commit 3de585e)

# Conflicts:
#	testing/integration/upgrade_test.go
pchila added a commit that referenced this pull request Aug 4, 2023
This PR filters out versions that too new from agent upgrade integration
tests, allowing backport of those test on release branches.

This PR needs to backported together with #2955 onto 8.9 branch

We want to have working upgrade tests with relevant versions also on
release branches
pchila added a commit that referenced this pull request Aug 4, 2023
… upgrade tests (#3172)

This is an automatic backport of pull request #3169 done by
[Mergify](https://mergify.com).

Co-authored-by: Paolo Chila <paolo.chila@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.9.0 Automated backport with mergify skip-changelog Team:Elastic-Agent Label for the Agent team Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants