Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Widget extra props down to its div #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pass Widget extra props down to its div #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions __tests__/ratings.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ test('Ratings renders correctly', ()=> {
svgIconPath="M2 1 h1 v1 h1 v1 h-1 v1 h-1 v-1 h-1 v-1 h1 z"
/>
<Ratings.Widget widgetHoverColor="black" />
<Ratings.Widget
<Ratings.Widget
/>
</Ratings>
);
Expand Down Expand Up @@ -55,7 +55,7 @@ it('changes rating when clicked', ()=> {
svgIconPath="M2 1 h1 v1 h1 v1 h-1 v1 h-1 v-1 h-1 v-1 h1 z"
/>
<Ratings.Widget widgetHoverColor="black" />
<Ratings.Widget
<Ratings.Widget
/>
</Ratings>
);
Expand All @@ -70,4 +70,31 @@ it('changes rating when clicked', ()=> {
fourthStar = wrapper.find(Ratings.Widget).at(3);
expect(fourthStar.prop('isSelected')).toBe(true);
expect(wrapper.prop('rating')).toEqual(NEXT_RATING);
});
});

it('passes Widget extra props down to the div', () => {
const wrapper = mount(
<Ratings
rating={3}
widgetRatedColors="blue"
changeRating={() => {}}
>
<Ratings.Widget data-testid="star-1"/>
<Ratings.Widget
data-testid="star-2"
svgIconViewBox="0 0 106.059 106.059"
svgIconPath="M90.546,15.518C69.858-5.172,36.199-5.172,15.515,15.513C-5.173,36.198-5.171,69.858,15.517,90.547 c20.682,20.684,54.341,20.684,75.027-0.004C111.23,69.858,111.229,36.2,90.546,15.518z M84.757,84.758 c-17.494,17.494-45.96,17.496-63.455,0.002c-17.498-17.497-17.496-45.966,0-63.46C38.796,3.807,67.261,3.805,84.759,21.302 C102.253,38.796,102.251,67.265,84.757,84.758z M33.24,38.671c0-3.424,2.777-6.201,6.201-6.201c3.423,0,6.2,2.776,6.2,6.201 c0,3.426-2.777,6.202-6.2,6.202C36.017,44.873,33.24,42.097,33.24,38.671z M61.357,38.671c0-3.424,2.779-6.201,6.203-6.201 c3.423,0,6.2,2.776,6.2,6.201c0,3.426-2.776,6.202-6.2,6.202S61.357,42.097,61.357,38.671z M76.017,64.068 c-3.843,8.887-12.843,14.629-22.927,14.629c-10.301,0-19.354-5.771-23.064-14.703c-0.636-1.529,0.089-3.285,1.62-3.921 c0.376-0.155,0.766-0.229,1.15-0.229c1.176,0,2.292,0.695,2.771,1.85c2.777,6.686,9.655,11.004,17.523,11.004 c7.69,0,14.528-4.321,17.42-11.011c0.658-1.521,2.424-2.222,3.944-1.563S76.675,62.548,76.017,64.068z"
/>
<Ratings.Widget
widgetDimension="60px"
svgIconViewBox="0 0 5 5"
svgIconPath="M2 1 h1 v1 h1 v1 h-1 v1 h-1 v-1 h-1 v-1 h1 z"
/>
<Ratings.Widget widgetHoverColor="black" />
<Ratings.Widget id="five-stars"/>
</Ratings>
);
expect(wrapper.find('div[data-testid="star-1"]').length).toEqual(1);
expect(wrapper.find('div[data-testid="star-2"]').length).toEqual(1);
expect(wrapper.find('div#five-stars').length).toEqual(1);
});
21 changes: 19 additions & 2 deletions src/widget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,23 @@ class Widget extends Component {
svgIconViewBox,
svgIconPath,
svg,
hasCustomGradientColor
hasCustomGradientColor,
gradientPathName,
hoverMode,
ignoreInlineStyles,
isCurrentHoveredWidget,
isFirstWidget,
isHovered,
isLastWidget,
isPartiallyFullWidget,
isSelected,
selectedRating,
widgetDimension,
widgetEmptyColor,
widgetHoverColor,
widgetRatedColor,
widgetSpacing,
...otherProps
} = this.props;
let customSvg = svg;
if (React.isValidElement(customSvg)) {
Expand All @@ -166,6 +182,7 @@ class Widget extends Component {
onMouseEnter={hoverOverWidget}
onMouseLeave={unHoverOverWidget}
onClick={changeRating}
{...otherProps}
>
{customSvg ? customSvg :
<svg
Expand Down Expand Up @@ -212,4 +229,4 @@ Widget.propTypes = {
widgetSpacing: PropTypes.string,
};

export default Widget;
export default Widget;