Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve displaying #38

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

scardinius
Copy link

Hi,

here is my modification for improving displaying information about contact and/or relationship.

At new setting page civicrm/admin/setting/relationshipblock?reset=1 accessed from Admin Console you can add additional fields, like phone, email or custom fields from relationship.

  • Contact fields - Additional contact fields displayed on block
  • Relationship fields - Additional relationship fields displayed on block
  • Display labels - Decide whether before value will be displayed a label of field, with options:
    • No, only value of fields
    • Yes, each field has own label

Configuration example

relationship-block-settings

What do you think about such feature?

@scardinius scardinius marked this pull request as ready for review March 17, 2022 14:47
@colemanw
Copy link
Collaborator

@scardinius I see you put a lot of work into this! Very impressive first contribution!
I like the idea of more flexibility, and your implementation looks clean and correct.

However, I'm concerned that the functionality you've added here overlaps with SearchKit. For that matter, this entire extension is basically obsolete now that we have SearchKit, and it all could be reduced to an empty extension with a packaged search display + afform set to display on the contact summary screen.

Given that, I'm not sure what we should do with this PR. Any thoughts @eileenmcnaughton?

@eileenmcnaughton
Copy link
Owner

@colemanw I guess this block is editable in a way a search kit wouldn't be

@colemanw
Copy link
Collaborator

That's true. Are these new fields editable as well @scardinius ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants