Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize block/header with jam codec #47

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Serialize block/header with jam codec #47

merged 4 commits into from
Aug 27, 2024

Conversation

pantrif
Copy link
Contributor

@pantrif pantrif commented Aug 23, 2024

In this PR:

  • Refactored the jam codec to simplify it, retaining only the two methods: marshal and unmarshal.
  • Added codec logic similar to the scale pkg (using recursion to serialize structs)
  • Switch to jam encoding in the header test
  • Created tests for block serialization using the new jam codec.

Part of this #6

@asmie asmie requested a review from a team August 23, 2024 12:00
carlos-romano
carlos-romano approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@carlos-romano carlos-romano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good, hopefully it will fit all required uses 👍

@pantrif pantrif merged commit eaed359 into main Aug 27, 2024
2 checks passed
@pantrif pantrif deleted the feat/serialize-block branch August 27, 2024 07:22
@carlos-romano carlos-romano mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-romano carlos-romano carlos-romano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pantrif @carlos-romano