Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing argument to trigger_deprecation call #57

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

jeanseba
Copy link

In branch 2.4, this breaks any remaining use of getUsername()

@drupol
Copy link
Member

drupol commented Oct 23, 2023

Nice catch!

@drupol drupol merged commit 7fa65eb into ecphp:2.4 Oct 23, 2023
7 of 13 checks passed
@drupol
Copy link
Member

drupol commented Oct 23, 2023

I just released version 2.4.2 including your fix.

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants