Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced pub sub #854

Merged
merged 22 commits into from
Dec 12, 2024
Merged

Conversation

DenisBiryukov91
Copy link
Contributor

add support for advanced publisher and advanced subscriber;

@DenisBiryukov91 DenisBiryukov91 marked this pull request as draft December 10, 2024 15:50
Copy link

PR missing one of the required labels: {'enhancement', 'breaking-change', 'documentation', 'bug', 'internal', 'dependencies', 'new feature'}

@DenisBiryukov91 DenisBiryukov91 added enhancement New feature or request api sync Synchronize API with other bindings labels Dec 10, 2024
@DenisBiryukov91 DenisBiryukov91 marked this pull request as ready for review December 11, 2024 13:43
Copy link
Contributor

@milyin milyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no test for new advanced subscriber.
And maybe it's better not to delete existing test even if functionality is deprecated.

examples/z_advanced_pub.c Outdated Show resolved Hide resolved
src/advanced_publisher.rs Outdated Show resolved Hide resolved
src/advanced_publisher.rs Outdated Show resolved Hide resolved
src/advanced_publisher.rs Outdated Show resolved Hide resolved
src/advanced_publisher.rs Show resolved Hide resolved
src/advanced_subscriber.rs Outdated Show resolved Hide resolved
@DenisBiryukov91
Copy link
Contributor Author

DenisBiryukov91 commented Dec 11, 2024

There is no test for new advanced subscriber. And maybe it's better not to delete existing test even if functionality is deprecated.

Added advanced_pub_sub test.
Restored querying_subscriber-pub_cache test.

@DenisBiryukov91 DenisBiryukov91 force-pushed the advanced-pub-sub branch 2 times, most recently from 147f23e to 1fe19a6 Compare December 12, 2024 11:08
@milyin milyin merged commit ceec66b into eclipse-zenoh:main Dec 12, 2024
19 checks passed
@DenisBiryukov91 DenisBiryukov91 deleted the advanced-pub-sub branch December 16, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api sync Synchronize API with other bindings enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants