Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21571] Add missing supported types to plotjuggler #59

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

Carlosespicur
Copy link
Contributor

This PR allows to show in Plotjuggler previously not supported members (maps, bitset, bitmask and union types).
Main Changes

  • Code simplified using JSON serializer. Creating empty structures to store data and check type kind is not more necessary.
  • PlotJuggler now shows only streamed data, avoiding empty time series.

Comments
Due to implementation of JSON serializer, it is compulsory to consider a type with a struct parent. The rest types are only supported as type members

This PR needs to be merged after:

@Carlosespicur Carlosespicur changed the base branch from main to feature/fastdds3-migration September 10, 2024 13:29
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur force-pushed the plotjuggler-json-test branch 2 times, most recently from e2ed782 to 246fd31 Compare September 16, 2024 08:30
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
…a type

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@rsanchez15 rsanchez15 merged commit 1b5d7b5 into feature/fastdds3-migration Sep 16, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants