[IND-481] Remove non-SQL implementation of creating initial rows

[lcwik]

Changelist

[IND-481] Remove non-SQL implementation of creating initial rows

More clean-up before migration to using a SQL based block processor.

Test Plan

Updated existing tests.

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

[linear]

IND-481 Update ender block handler with a single SQL handler that delegates to sub-handlers

Update ender block handler with a single SQL handler that delegates to sub-handlers

[coderabbitai]

Walkthrough

The recent updates involve the removal of a configuration option and associated functionality that allowed the use of SQL functions to create initial rows in a database. The test cases have been updated to reflect the removal of the useSqlFunction parameter. Additionally, the codebase has been simplified by removing several functions related to the creation of Tendermint events and transactions, and the onMessage function has been modified to use a different method for creating initial rows.

Changes

File Path	Change Summary
.../ender/__tests__/lib/on-message.test.ts	Removed useSqlFunction parameter from multiple test cases.
.../ender/src/config.ts	Removed USE_SQL_FUNCTION_TO_CREATE_INITIAL_ROWS configuration from configSchema.
.../ender/src/lib/on-message.ts	Removed multiple functions (createTendermintEvents, createTendermintEvent, createTransactions, createInitialRowsViaSqlFunction) and an import (IndexerTendermintEvent). Updated onMessage to use runFuncWithTimingStat for creating initial rows and modified createInitialRows to directly create rows or use SQL function based on configuration.

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between cf6c8e9 and 28c60e5.

Files selected for processing (3)

• indexer/services/ender/tests/lib/on-message.test.ts (5 hunks)
• indexer/services/ender/src/config.ts (1 hunks)
• indexer/services/ender/src/lib/on-message.ts (5 hunks)

Files skipped from review due to trivial changes (1)

• indexer/services/ender/src/config.ts

Additional comments: 7

indexer/services/ender/__tests__/lib/on-message.test.ts (5)

• 166-172: The removal of the useSqlFunction parameter from the test case 'successfully processes block with transaction event' is consistent with the summary.

• 219-225: The removal of the useSqlFunction parameter from the test case 'successfully processes block with transaction event with unset version' is consistent with the summary.

• 544-550: The removal of the useSqlFunction parameter from the test case 'successfully processes block with block event' is consistent with the summary.

• 589-592: The removal of the useSqlFunction parameter from the test case 'successfully processes block with transaction event and block event' is consistent with the summary.

• 642-645: The removal of the useSqlFunction parameter from the test case 'successfully processes block with multiple transactions' is consistent with the summary.

indexer/services/ender/src/lib/on-message.ts (2)

• 215-221: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [218-243]

The createInitialRows function now always uses a SQL function to create initial rows. Ensure that this change is intentional and that there is no longer a need for a non-SQL path, as the configuration and conditional logic for such a path are not present.

• 68-80: The transaction isolation level is set to READ_UNCOMMITTED, which is the weakest level and allows for dirty reads. Confirm that this isolation level is appropriate for the operations within the onMessage function and that the potential for dirty reads is acceptable in this context.