Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IND-481] Delete price cache in ender. #815

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[IND-481] Delete price cache in ender. #815

merged 1 commit into from
Nov 29, 2023

Conversation

lcwik
Copy link
Contributor

@lcwik lcwik commented Nov 28, 2023

Changelist

[IND-481] Delete price cache in ender.

More clean-up before migration to SQL based block processor.

Test Plan

Updated existing tests.

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

More clean-up before migration to SQL based block processor.
Copy link

linear bot commented Nov 28, 2023

IND-481 Update ender block handler with a single SQL handler that delegates to sub-handlers

Update ender block handler with a single SQL handler that delegates to sub-handlers

Copy link
Contributor

coderabbitai bot commented Nov 28, 2023

Walkthrough

The changes across various files in the ender service indicate a removal of functionality related to a price cache. The price cache's import statements, function calls, and related expectations in tests have been deleted. This suggests that the service has either deprecated the use of a price cache or has moved the functionality elsewhere.

Changes

File Path Change Summary
.../block-cache.test.ts Removed import and usage of clearPriceMap and getPriceMap from the price cache.
.../funding-handler.test.ts Removed a call to startPriceCache in the beforeEach block.
.../market-price-update-handler.test.ts Removed import of getPrice and related expectations for getPrice calls.
.../block-cache.ts Removed import of startPriceCache from the price cache.
.../market-price-update-handler.ts Removed import and call to updatePriceCacheWithPrice.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between cf6c8e9 and 2dc2561.
Files selected for processing (5)
  • indexer/services/ender/tests/caches/block-cache.test.ts (5 hunks)
  • indexer/services/ender/tests/handlers/funding-handler.test.ts (2 hunks)
  • indexer/services/ender/tests/handlers/markets/market-price-update-handler.test.ts (3 hunks)
  • indexer/services/ender/src/caches/block-cache.ts (2 hunks)
  • indexer/services/ender/src/handlers/markets/market-price-update-handler.ts (2 hunks)
Files skipped from review due to trivial changes (4)
  • indexer/services/ender/tests/caches/block-cache.test.ts
  • indexer/services/ender/tests/handlers/funding-handler.test.ts
  • indexer/services/ender/src/caches/block-cache.ts
  • indexer/services/ender/src/handlers/markets/market-price-update-handler.ts

@lcwik lcwik merged commit 3f5d937 into main Nov 29, 2023
11 checks passed
@lcwik lcwik deleted the lukeind481.3 branch November 29, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants