-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default athena snapshots to be off #775
Conversation
WalkthroughThe change in the codebase primarily revolves around the modification of a configuration setting in the Roundtable service. The Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -39,7 +39,7 @@ export const configSchema = { | |||
LOOPS_ENABLED_REMOVE_EXPIRED_ORDERS: parseBoolean({ default: true }), | |||
LOOPS_ORDERBOOK_INSTRUMENTATION: parseBoolean({ default: true }), | |||
LOOPS_CANCEL_STALE_ORDERS: parseBoolean({ default: true }), | |||
LOOPS_ENABLED_UPDATE_RESEARCH_ENVIRONMENT: parseBoolean({ default: true }), | |||
LOOPS_ENABLED_UPDATE_RESEARCH_ENVIRONMENT: parseBoolean({ default: false }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value for LOOPS_ENABLED_UPDATE_RESEARCH_ENVIRONMENT
has been changed from true
to false
. This change could potentially affect the behavior of the system related to updating the research environment. Please ensure that this change is intended and that it does not negatively impact any dependent systems or processes.
- LOOPS_ENABLED_UPDATE_RESEARCH_ENVIRONMENT: parseBoolean({ default: true }),
+ LOOPS_ENABLED_UPDATE_RESEARCH_ENVIRONMENT: parseBoolean({ default: false }),
Commitable suggestion
[!IMPORTANT]
Carefully review the code before committing. Make sure it correctly replaces the highlighted code, has no missing lines and indentaion issues.
LOOPS_ENABLED_UPDATE_RESEARCH_ENVIRONMENT: parseBoolean({ default: false }), | |
LOOPS_ENABLED_UPDATE_RESEARCH_ENVIRONMENT: parseBoolean({ default: false }), |
Changelist
External and dev indexers have no need to create athena snapshots. I have enabled athena snapshots for our staging, public-testnet, and mainnet.
Test Plan
was not tested
Author/Reviewer Checklist
state-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.