-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md for running single Indexer test file #1562
Update README.md for running single Indexer test file #1562
Conversation
WalkthroughThe recent update enhances the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- indexer/README.md (1 hunks)
Additional Context Used
LanguageTool (7)
indexer/README.md (7)
Near line 16: Try using a synonym here to elevate your writing.
Context: ...dYdX V4 application. The services that make up the V4 Indexer are: - ender: Receives o...
Near line 63: You might be missing the article “the” here.
Context: ...ge packages/ ``` - Updatepackage.json
name to `@dydxprotocol-ind...
Near line 73: You might be missing the article “the” here.
Context: ...ce services/ ``` - Updatepackage.json
name to ``, ...
Near line 127: You might be missing the article “the” here.
Context: ...s to Datadog, add the following flag to above command:--profile export-to-datadog
...
Near line 138: A comma might be missing here.
Context: ...p` again. ### Running local V4 node By default the Indexer services connect to a local...
Near line 197: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...I of locally run Indexercomlink
will serving API requests from `http://localhost:300...
Near line 205: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...cket messages from Indexersocks
will accepting websocket connections from `http://loca...
Path-based Instructions (1)
indexer/README.md (1)
Pattern
**/**
: Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.
### To run a single test file: | ||
`cd services/{service_name} && pnpm build && pnpm test -- {test_name}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the instructions for running a single test file to include more specific details.
- `cd services/{service_name} && pnpm build && pnpm test -- {test_name}`
+ `cd services/{service_name} && pnpm run build && pnpm run test -- {test_name}`
This change ensures that the commands are consistent with other parts of the document where pnpm run
is used for executing scripts.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
### To run a single test file: | |
`cd services/{service_name} && pnpm build && pnpm test -- {test_name}` | |
### To run a single test file: | |
`cd services/{service_name} && pnpm run build && pnpm run test -- {test_name}` |
Changelist
[Describe or list the changes made in this PR]
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.Summary by CodeRabbit