Add support for pagination at table level. (backport #1244) #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* feat(postgres): ✨ add transfer pagination support * test(postgres): ✅ add transfer pagination test * feat(comlink): ✨ add pagination for getTransfers * test(ender): ✅ update transfer handler test * feat(postgres): ✨ add fill pagination support * test(postgres): ✅ add fill pagination test * feat(comlink): ✨ add pagination for getTrades and getFills * test: ✅ update pagination tests updated pagination tests to also evaluate total pages. * feat(postgres): 🏷️ add explicit types added explicit types for fill and transfer tables. * feat(postgres): ✨ add order pagination support * test(postgres): ✅ add order pagination test * feat: ♻️ update order findAll usage * revert: ⏪ revert add pagination for getTransfers * revert: ⏪ revert add pagination for getTrades and getFills * feat: 🏷️ add explicit ts types * docs: 💡 add pagination todo comment * docs(postgres): 💡 improve pagination comment improve pagination comment thanks to coderabbitai. --------- Co-authored-by: Davide Segullo <davidesegullo@gmail.com> (cherry picked from commit e12ebf2)
6 tasks
|
Important Auto Review SkippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
dydxwill
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
This PR aims to solve #1239 issue.
Specifically, it modifies the low-level functions used by the API provided by the indexer to add the pagination feature.
Test Plan
Tests are delivered with the features.
We have not tested the environment with a full live (development) environment, but have performed unit tests.
We encourage you to perform full (integration) testing before merging.
Author/Reviewer Checklist
If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the
state-breakinglabel.No breaking changes.
If the PR has breaking postgres changes to the indexer add the
indexer-postgres-breakinglabel.No breaking changes.
If this PR isn't state-breaking but has changes that modify behavior in
PrepareProposalorProcessProposal, manually add the labelproposal-breaking.No changes in
PrepareProposalORProcessProposal.If this PR is one of many that implement a specific feature, manually label them all
feature:[feature-name].Probably should add feature:[support-pagination-in-transfers]
If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label
backport/[branch-name].Manually add any of the following labels:
refactor,chore,bug.Summary by CodeRabbit
New Features
Refactor
Tests
This is an automatic backport of pull request #1244 done by [Mergify](https://mergify.com).