Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-808] Add subaccount limit per pnl run #1527

Merged
merged 2 commits into from
May 16, 2024
Merged

[CT-808] Add subaccount limit per pnl run #1527

merged 2 commits into from
May 16, 2024

Conversation

dydxwill
Copy link
Contributor

@dydxwill dydxwill commented May 15, 2024 •
edited
Loading

Changelist

Context here
Add subaccount limit per pnl run.

Test Plan

Ran in testnet.

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features

    • Added a configuration constant to limit the number of accounts updated per run, improving system performance.

  • Enhancements

    • Enhanced error logging in task execution by including more parameters for better traceability.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 15, 2024 •
edited
Loading

Walkthrough

The recent updates introduce a new configuration constant, PNL_TICK_MAX_ACCOUNTS_PER_RUN, with a default value of 65000. This constant now limits the number of accounts processed per run in the getPnlTicksCreateObjects function. Additionally, error logging in the runTask function has been enhanced to include latestBlockHeight, latestBlockTime, and txId for better traceability.

Changes

Files Change Summary
indexer/services/roundtable/src/config.ts Added a new configuration constant PNL_TICK_MAX_ACCOUNTS_PER_RUN with a default value of 65000.
indexer/services/roundtable/src/helpers/pnl-ticks-helper.ts Updated getPnlTicksCreateObjects to limit accounts to update per run based on PNL_TICK_MAX_ACCOUNTS_PER_RUN.
indexer/services/roundtable/src/tasks/create-pnl-ticks.ts Enhanced runTask function to include latestBlockHeight, latestBlockTime, and txId in error logging.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 1c75d44 and 6ab9ea0.
Files selected for processing (3)
  • indexer/services/roundtable/src/config.ts (1 hunks)
  • indexer/services/roundtable/src/helpers/pnl-ticks-helper.ts (1 hunks)
  • indexer/services/roundtable/src/tasks/create-pnl-ticks.ts (1 hunks)
Files not reviewed due to errors (2)
  • indexer/services/roundtable/src/config.ts (no review received)
  • indexer/services/roundtable/src/helpers/pnl-ticks-helper.ts (no review received)
Additional Context Used
Path-based Instructions (3)
indexer/services/roundtable/src/tasks/create-pnl-ticks.ts (1)

Pattern **/**: Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.

indexer/services/roundtable/src/config.ts (1)

Pattern **/**: Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.

indexer/services/roundtable/src/helpers/pnl-ticks-helper.ts (1)

Pattern **/**: Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.

Additional comments not posted (1)
indexer/services/roundtable/src/tasks/create-pnl-ticks.ts (1)

56-58: Enhanced error logging with additional context.

coderabbitai[bot]
coderabbitai bot reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 6ab9ea0 and 6c7391d.
Files selected for processing (1)
  • indexer/services/roundtable/src/config.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • indexer/services/roundtable/src/config.ts

@dydxwill dydxwill changed the title Add subaccount limit per pnl run [CT-808] Add subaccount limit per pnl run May 16, 2024
@linear Linear
Copy link

linear bot commented May 16, 2024

CT-808 Testnet: Portfolio 90d / 30d chart dates incorrect

@dydxwill dydxwill merged commit 430c208 into main May 16, 2024
11 checks passed
@dydxwill dydxwill deleted the wl/pnlfix branch May 16, 2024 14:35
@dydxwill
Copy link
Contributor Author

https://github.com/Mergifyio backport release/indexer/v5.x

@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024 •
edited
Loading

backport release/indexer/v5.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 17, 2024
@dydxwill @mergify
[CT-808] Add subaccount limit per pnl run (#1527)
46b1dbb 
* add subaccount limit

(cherry picked from commit 430c208)
@mergify mergify bot mentioned this pull request May 17, 2024
Merged
6 tasks
dydxwill added a commit that referenced this pull request May 17, 2024
@mergify @dydxwill
[CT-808] Add subaccount limit per pnl run (#1527) (#1537)
c26b459 
* add subaccount limit

(cherry picked from commit 430c208)

Co-authored-by: dydxwill <119354122+dydxwill@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@affanv14 affanv14 affanv14 approved these changes

Assignees
No one assigned
Labels
indexer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dydxwill @affanv14