Refactor out looking up clob pair into SQL function. (#784)

indexer/services/ender/src/helpers/postgres/postgres-functions.ts

@@ -42,6 +42,7 @@ const scripts: string[] = [
   'dydx_from_serializable_int.sql',
   'dydx_funding_handler.sql',
   'dydx_get_fee_from_liquidity.sql',
+  'dydx_get_perpetual_market_for_clob_pair.sql',
   'dydx_get_order_status.sql',
   'dydx_get_total_filled_from_liquidity.sql',
   'dydx_get_weighted_average.sql',

indexer/services/ender/src/scripts/dydx_get_perpetual_market_for_clob_pair.sql

@@ -0,0 +1,23 @@
+/**
+  Returns the perpetual market record for the provided clob pair.
+
+  Parameters:
+    - clob_pair_id: The clob pair id.
+  Returns: the only perpetual market for the clob pair. Throws an exception if not exactly one row is found.
+*/
+CREATE OR REPLACE FUNCTION dydx_get_perpetual_market_for_clob_pair(
+    clob_pair_id bigint
+) RETURNS perpetual_markets AS $$
+DECLARE
+    perpetual_market_record perpetual_markets%ROWTYPE;
+BEGIN
+    SELECT * INTO STRICT perpetual_market_record FROM perpetual_markets WHERE "clobPairId" = clob_pair_id;
+    RETURN perpetual_market_record;
+EXCEPTION
+    WHEN NO_DATA_FOUND THEN
+        RAISE EXCEPTION 'Unable to find perpetual market with clobPairId: %', clob_pair_id;
+    WHEN TOO_MANY_ROWS THEN
+        /** This should never happen and if it ever were to would indicate that the table has malformed data. */
+        RAISE EXCEPTION 'Found multiple perpetual markets with clobPairId: %', clob_pair_id;
+END;
+$$ LANGUAGE plpgsql;

indexer/services/ender/src/scripts/dydx_liquidation_fill_handler_per_order.sql

@@ -52,15 +52,7 @@ BEGIN
         clob_pair_id = jsonb_extract_path(order_, 'clobPairId')::bigint;
     END IF;
 
-    BEGIN
-        SELECT * INTO STRICT perpetual_market_record FROM perpetual_markets WHERE "clobPairId" = clob_pair_id;
-    EXCEPTION
-        WHEN NO_DATA_FOUND THEN
-            RAISE EXCEPTION 'Unable to find perpetual market with clobPairId %', clob_pair_id;
-        WHEN TOO_MANY_ROWS THEN
-            /** This should never happen and if it ever were to would indicate that the table has malformed data. */
-            RAISE EXCEPTION 'Found multiple perpetual markets with clobPairId %', clob_pair_id;
-    END;
+    perpetual_market_record = dydx_get_perpetual_market_for_clob_pair(clob_pair_id);
 
     BEGIN
         SELECT * INTO STRICT asset_record FROM assets WHERE "id" = usdc_asset_id;

indexer/services/ender/src/scripts/dydx_order_fill_handler_per_order.sql

@@ -46,15 +46,7 @@ BEGIN
     order_ = event_data->field;
     maker_order = event_data->'makerOrder';
     clob_pair_id = jsonb_extract_path(order_, 'orderId', 'clobPairId')::bigint;
-    BEGIN
-        SELECT * INTO STRICT perpetual_market_record FROM perpetual_markets WHERE "clobPairId" = clob_pair_id;
-    EXCEPTION
-        WHEN NO_DATA_FOUND THEN
-            RAISE EXCEPTION 'Unable to find perpetual market with clobPairId %', clob_pair_id;
-        WHEN TOO_MANY_ROWS THEN
-            /** This should never happen and if it ever were to would indicate that the table has malformed data. */
-            RAISE EXCEPTION 'Found multiple perpetual markets with clobPairId %', clob_pair_id;
-    END;
+    perpetual_market_record = dydx_get_perpetual_market_for_clob_pair(clob_pair_id);
 
     BEGIN
         SELECT * INTO STRICT asset_record FROM assets WHERE "id" = usdc_asset_id;

indexer/services/ender/src/scripts/dydx_stateful_order_handler.sql

@@ -25,15 +25,7 @@ BEGIN
         order_ = COALESCE(event_data->'orderPlace'->'order', event_data->'longTermOrderPlacement'->'order', event_data->'conditionalOrderPlacement'->'order');
         clob_pair_id = (order_->'orderId'->'clobPairId')::bigint;
 
-        BEGIN
-            SELECT * INTO STRICT perpetual_market_record FROM perpetual_markets WHERE "clobPairId" = clob_pair_id;
-        EXCEPTION
-            WHEN NO_DATA_FOUND THEN
-                RAISE EXCEPTION 'Unable to find perpetual market with clobPairId: %', clob_pair_id;
-            WHEN TOO_MANY_ROWS THEN
-                /** This should never happen and if it ever were to would indicate that the table has malformed data. */
-                RAISE EXCEPTION 'Found multiple perpetual markets with clobPairId: %', clob_pair_id;
-        END;
+        perpetual_market_record = dydx_get_perpetual_market_for_clob_pair(clob_pair_id);
 
         /**
           Calculate sizes, prices, and fill amounts.
@@ -113,15 +105,7 @@ BEGIN
         END CASE;
 
         clob_pair_id = (order_id->'clobPairId')::bigint;
-        BEGIN
-            SELECT * INTO STRICT perpetual_market_record FROM perpetual_markets WHERE "clobPairId" = clob_pair_id;
-        EXCEPTION
-            WHEN NO_DATA_FOUND THEN
-                RAISE EXCEPTION 'Unable to find perpetual market with clobPairId: %', clob_pair_id;
-            WHEN TOO_MANY_ROWS THEN
-                /** This should never happen and if it ever were to would indicate that the table has malformed data. */
-                RAISE EXCEPTION 'Found multiple perpetual markets with clobPairId: %', clob_pair_id;
-        END;
+        perpetual_market_record = dydx_get_perpetual_market_for_clob_pair(clob_pair_id);
 
         subaccount_id = dydx_uuid_from_subaccount_id(order_id->'subaccountId');
         SELECT * INTO subaccount_record FROM subaccounts WHERE "id" = subaccount_id;

indexer/services/ender/src/scripts/dydx_update_perpetual_position_aggregate_fields.sql

@@ -15,7 +15,7 @@ CREATE OR REPLACE FUNCTION dydx_update_perpetual_position_aggregate_fields(
     price numeric
 ) RETURNS perpetual_positions AS $$
 DECLARE
-    perpetual_position_record RECORD;
+    perpetual_position_record perpetual_positions%ROWTYPE;
     sum_open numeric;
     entry_price numeric;
     sum_close numeric;