[refactor] Remove errors from subaccounts keeper functions that don't…

… return errors (#678)

protocol/x/subaccounts/keeper/subaccount.go

@@ -283,19 +283,13 @@ func (k Keeper) UpdateSubaccounts(
 	}
 
 	// Apply the updates to perpetual positions.
-	success, err = UpdatePerpetualPositions(
+	UpdatePerpetualPositions(
 		settledUpdates,
 		perpIdToFundingIndex,
 	)
-	if !success || err != nil {
-		return success, successPerUpdate, err
-	}
 
 	// Apply the updates to asset positions.
-	success, err = UpdateAssetPositions(settledUpdates)
-	if !success || err != nil {
-		return success, successPerUpdate, err
-	}
+	UpdateAssetPositions(settledUpdates)
 
 	// Apply all updates, including a subaccount update event in the Indexer block message
 	// per update and emit a cometbft event for each settled funding payment.
@@ -433,10 +427,8 @@ func (k Keeper) getSettledSubaccount(
 		// division result always rounds towards negative infinity.
 		totalNetSettlementPpm.Div(totalNetSettlementPpm, lib.BigIntOneMillion()),
 	)
-	err = newSubaccount.SetUsdcAssetPosition(newUsdcPosition)
-	if err != nil {
-		return types.Subaccount{}, nil, err
-	}
+	// TODO(CLOB-993): Remove this function and use `UpdateAssetPositions` instead.
+	newSubaccount.SetUsdcAssetPosition(newUsdcPosition)
 	return newSubaccount, fundingPayments, nil
 }
 

protocol/x/subaccounts/keeper/subaccount_helper.go

@@ -104,9 +104,6 @@ func getUpdatedPerpetualPositions(
 func UpdatePerpetualPositions(
 	settledUpdates []settledUpdate,
 	perpIdToFundingIndex map[uint32]dtypes.SerializableInt,
-) (
-	success bool,
-	err error,
 ) {
 	// Apply the updates.
 	for i, u := range settledUpdates {
@@ -164,16 +161,12 @@ func UpdatePerpetualPositions(
 
 		settledUpdates[i].SettledSubaccount.PerpetualPositions = perpetualPositions
 	}
-	return true, nil
 }
 
 // For each settledUpdate in settledUpdates, updates its SettledSubaccount.AssetPositions
 // to reflect settledUpdate.AssetUpdates.
 func UpdateAssetPositions(
 	settledUpdates []settledUpdate,
-) (
-	success bool,
-	err error,
 ) {
 	// Apply the updates.
 	for i, u := range settledUpdates {
@@ -226,5 +219,4 @@ func UpdateAssetPositions(
 
 		settledUpdates[i].SettledSubaccount.AssetPositions = assetPositions
 	}
-	return true, nil
 }

protocol/x/subaccounts/types/subaccount.go

@@ -73,26 +73,25 @@ func (m *Subaccount) GetUsdcPosition() *big.Int {
 }
 
 // SetUsdcAssetPosition sets the balance of the USDC asset position to `newUsdcPosition`.
-// If the absolute value of `newUsdcPosition` cannot be represented in a uint64,
-// an error is returned.
-func (m *Subaccount) SetUsdcAssetPosition(newUsdcPosition *big.Int) error {
-	if m != nil {
-		usdcAssetPosition := m.getUsdcAssetPosition()
-		if newUsdcPosition == nil || newUsdcPosition.Sign() == 0 {
-			if usdcAssetPosition != nil {
-				m.AssetPositions = m.AssetPositions[1:]
-			}
-		} else {
-			if usdcAssetPosition == nil {
-				usdcAssetPosition = &AssetPosition{
-					AssetId: assettypes.AssetUsdc.Id,
-				}
-				m.AssetPositions = append([]*AssetPosition{usdcAssetPosition}, m.AssetPositions...)
+func (m *Subaccount) SetUsdcAssetPosition(newUsdcPosition *big.Int) {
+	if m == nil {
+		return
+	}
+
+	usdcAssetPosition := m.getUsdcAssetPosition()
+	if newUsdcPosition == nil || newUsdcPosition.Sign() == 0 {
+		if usdcAssetPosition != nil {
+			m.AssetPositions = m.AssetPositions[1:]
+		}
+	} else {
+		if usdcAssetPosition == nil {
+			usdcAssetPosition = &AssetPosition{
+				AssetId: assettypes.AssetUsdc.Id,
 			}
-			usdcAssetPosition.Quantums = dtypes.NewIntFromBigInt(newUsdcPosition)
+			m.AssetPositions = append([]*AssetPosition{usdcAssetPosition}, m.AssetPositions...)
 		}
+		usdcAssetPosition.Quantums = dtypes.NewIntFromBigInt(newUsdcPosition)
 	}
-	return nil
 }
 
 func (m *Subaccount) getUsdcAssetPosition() *AssetPosition {

protocol/x/subaccounts/types/subaccount_test.go

@@ -205,7 +205,6 @@ func TestSetSubaccountQuoteBalance(t *testing.T) {
 		subaccount             *types.Subaccount
 		newQuoteBalance        *big.Int
 		expectedAssetPositions []*types.AssetPosition
-		expectedError          error
 	}{
 		"can set nil subaccount": {
 			subaccount:      nil,
@@ -311,12 +310,7 @@ func TestSetSubaccountQuoteBalance(t *testing.T) {
 	// Run tests.
 	for name, tc := range tests {
 		t.Run(name, func(t *testing.T) {
-			err := tc.subaccount.SetUsdcAssetPosition(tc.newQuoteBalance)
-			if tc.expectedError == nil {
-				require.NoError(t, err)
-			} else {
-				require.ErrorIs(t, tc.expectedError, err)
-			}
+			tc.subaccount.SetUsdcAssetPosition(tc.newQuoteBalance)
 			if tc.subaccount != nil {
 				require.Equal(
 					t,