-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality Update #2033
Open
Mil4n0r
wants to merge
167
commits into
master
Choose a base branch
from
Mil4n0r/code_quality_monorepo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Code Quality Update #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o Mil4n0r/code_quality_monorepo
…o Mil4n0r/code_quality_monorepo
…o Mil4n0r/code_quality_monorepo
…o Mil4n0r/code_quality_monorepo
…halstack-react into Mil4n0r/code_quality_monorepo
…halstack-react into Mil4n0r/code_quality_monorepo
…halstack-react into Mil4n0r/code_quality_monorepo
…logy/halstack-react into Mil4n0r/code_quality_monorepo
…o Mil4n0r/code_quality_monorepo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/lib
directory./website
as needed.Description
We want to follow the best practices and achieve a higher code quality by using automatic tools (Husky, Prettier, ESLint and Staged-Lint). This PR contains both the setup of the tools and the fix of most existing code quality issues.
The goal to achieve is to remove all the custom rules existing in the eslint configuration file and pass with no errors and no warnings.
Closes #2031, #2043