feat(cb2-11930): force cert number to be set on amended specialist tests #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcarr-bjss
approved these changes
May 3, 2024
naathanbrown
approved these changes
May 3, 2024
me-matt
approved these changes
May 3, 2024
| @@ -148,6 +148,12 @@ export class VehicleTestController implements IVehicleTestController { | |||
| } | |||
| // map testTypes back after validation | |||
| payload.testTypes = testTypes; | |||
| payload.testTypes.forEach(x=>{ | |||
There was a problem hiding this comment.
I think it would probably be better to do. this for loop above where the assigning payload.testTypes to testTypes to keep all of the processing together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
force cert number to be set on amended specialist tests
Makes amended specialist tests set their certificate number to the test number, if a certificate number is no present in the payload
link to ticket number
Checklist