Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cb2-14934): create recalls brokering API #169

Merged
merged 39 commits into from
Nov 29, 2024
Merged

feat(cb2-14934): create recalls brokering API #169

merged 39 commits into from
Nov 29, 2024

Conversation

naathanbrown
Copy link
Contributor

Description

Create recalls brokering API.

Related issue: 14394

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works

naathanbrown and others added 22 commits November 14, 2024 09:16
@naathanbrown
squash commits
be3c231
@naathanbrown
feat(cb2-14394): start refactoring for caching
ed959b1
@naathanbrown
feat(cb2-14394): refactor handler file
d67d78c
@naathanbrown
feat(cb2-14394): unit test single vin validator
02473bb
@naathanbrown
feat(cb2-14394): test mot secret getting
8a3d3cc
@naathanbrown
feat(cb2-14394): change to main recalls handler
a25c8de
@naathanbrown
feat(cb2-14394): add error log
dba948c
@naathanbrown
feat(cb2-14394): get token and call recalls
bb4ed92
@naathanbrown
feat(cb2-14394): get token and call recalls
f868597
@naathanbrown
feat(cb2-14394): get token and call recalls
9dcc6d1
@naathanbrown
feat(cb2-14394): get token and call recalls
5e6449c
@naathanbrown
feat(cb2-14394): get token and call recalls
c62a57b
@naathanbrown
feat(cb2-14394): get token and call recalls
230c566
@naathanbrown
feat(cb2-14394): update code to work without secrets manager vpc
39f133b
@naathanbrown
feat(cb2-14394): update package json
c398215
@naathanbrown
feat(cb2-14394): test filter MOT recalls funciton
3c3dac0
@m-mullen
feat(CB2-14394): recalls handler unit test
7b30c8d
@m-mullen
feat(CB2-14394): recalls utils unit tests
36130e6
@naathanbrown
Merge remote-tracking branch 'origin/develop' into feature/CB2-14394
a177c37
@naathanbrown
feat(cb2-14394): update docs
8fed1b2
@naathanbrown
feat(cb2-14394): refactor and tidy
306e4e7
@naathanbrown
feat(cb2-14394): add happy path test
6b6c5c4
@naathanbrown naathanbrown marked this pull request as draft November 19, 2024 11:09
me-matt
me-matt reviewed Nov 19, 2024
View reviewed changes
src/handler/recalls.ts Outdated Show resolved Hide resolved
matthew2564
matthew2564 reviewed Nov 21, 2024
View reviewed changes
src/util/recalls.ts Outdated Show resolved Hide resolved
cb-cs
cb-cs reviewed Nov 21, 2024
View reviewed changes
src/handler/recalls.ts Outdated Show resolved Hide resolved
cb-cs
cb-cs reviewed Nov 21, 2024
View reviewed changes
src/handler/recalls.ts Outdated Show resolved Hide resolved
matthew2564
matthew2564 reviewed Nov 21, 2024
View reviewed changes
src/handler/recalls.ts Outdated Show resolved Hide resolved
cb-cs
cb-cs reviewed Nov 22, 2024
View reviewed changes
src/util/recalls.ts Outdated Show resolved Hide resolved
@naathanbrown naathanbrown marked this pull request as ready for review November 25, 2024 11:13
Daniel-Searle
Daniel-Searle reviewed Nov 25, 2024
View reviewed changes
src/handler/recalls.ts Outdated Show resolved Hide resolved
src/handler/recalls.ts Outdated Show resolved Hide resolved
src/handler/recalls.ts Outdated Show resolved Hide resolved
src/models/motRecalls.ts Show resolved Hide resolved
src/util/recalls.ts Outdated Show resolved Hide resolved
tests/unit/handler/recalls.unit.test.ts Outdated Show resolved Hide resolved
tests/unit/handler/recalls.unit.test.ts Outdated Show resolved Hide resolved
tests/unit/handler/recalls.unit.test.ts Outdated Show resolved Hide resolved
tests/unit/util/recalls.unit.test.ts Outdated Show resolved Hide resolved
tests/unit/validators/recalls.unit.test.ts Outdated Show resolved Hide resolved
cb-cs
cb-cs reviewed Nov 25, 2024
View reviewed changes
src/util/recalls.ts Outdated Show resolved Hide resolved
cb-cs
cb-cs reviewed Nov 25, 2024
View reviewed changes
src/handler/recalls.ts Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 25, 2024
View reviewed changes
tests/unit/util/motRecalls.unit.test.ts Dismissed Show dismissed Hide dismissed
tests/unit/util/motRecalls.unit.test.ts Dismissed Show dismissed Hide dismissed
tests/unit/util/motRecalls.unit.test.ts Dismissed Show dismissed Hide dismissed
@m-coslett m-coslett self-requested a review November 29, 2024 12:40
@m-coslett m-coslett merged commit 2f8bcac into develop Nov 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew2564 matthew2564 matthew2564 left review comments

@me-matt me-matt me-matt left review comments

@Daniel-Searle Daniel-Searle Daniel-Searle approved these changes

@cb-cs cb-cs cb-cs approved these changes

@m-coslett m-coslett m-coslett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@naathanbrown @me-matt @matthew2564 @m-coslett @cb-cs @Daniel-Searle @m-mullen @JoshCarter-ops