Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cb2-11293): updated spec file and type definitions file #124

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

kcarr-bjss
Copy link
Contributor

Description

Updated the spec file to Open API V3 and updated the type definitions file to the latest version

Related issue: CB2-11293

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works

docs/spec.yml Outdated
content:
application/json:
schema:
$ref: "https://raw.githubusercontent.com/dvsa/cvs-type-definitions/develop/json-schemas/v3/tech-record/put/psv/complete/index.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need a rebase? This is showing as your change / commit, even though it was merged into develop 14/03.

Also - there appears to be 3 references to /develop in the spec file, rather than /v6.1.0, (this line for example).

Do you happen to know why that is the case?

I'm getting the following error in the IDE when viewing the spec file locally...

Something went wrong...
Invalid JSON pointer: https://raw.githubusercontent.com/dvsa/cvs-type-definitions/develop/json-schemas/v3/tech-record/put/psv/complete/index.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the references to develop from the spec file. Attempted a rebase however it would appear the section of code in question was actually deleted in develop due to conflicts with Open API v3.

@kcarr-bjss kcarr-bjss merged commit 4d5b286 into develop Mar 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants