Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Raid Maps command #53

Merged
merged 8 commits into from
Jan 28, 2024
Merged

Conversation

dvillavicencio
Copy link
Owner

This pull request gives the base-line for the /raid_maps slash-command. For the initial version, the only raid that will have infographics is Last Wish. Subsequent tasks in this Project will be linked to add more infographics relating to each one of the raids.

@dvillavicencio dvillavicencio self-assigned this Jan 23, 2024
@dvillavicencio dvillavicencio linked an issue Jan 23, 2024 that may be closed by this pull request
… autocomplete and rewriting base test suite
Copy link

gitguardian bot commented Jan 27, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
9231892 Generic High Entropy Secret c637998 src/test/java/com/danielvm/destiny2bot/integration/InteractionControllerTest.java View secret
9231892 Generic High Entropy Secret c637998 src/test/java/com/danielvm/destiny2bot/integration/InteractionControllerTest.java View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@dvillavicencio dvillavicencio merged commit 3d6f836 into main Jan 28, 2024
2 checks passed
@dvillavicencio dvillavicencio deleted the implement-raid-maps-command branch January 28, 2024 05:32
@dvillavicencio dvillavicencio added this to the Version 1.0.0 milestone Feb 19, 2024
@dvillavicencio dvillavicencio added the Feature Request A request for new functionality label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request A request for new functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Raid-map command
1 participant