Skip to content

Commit

Permalink
Fixed broken test because I added null checks, this is a good sign
Browse files Browse the repository at this point in the history
  • Loading branch information
Daniel Villavicencio authored and Daniel Villavicencio committed Jul 23, 2024
1 parent f82735f commit 1c09f25
Show file tree
Hide file tree
Showing 2 changed files with 211 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,210 @@
{
"Response": {
"displayProperties": {
"description": "Machinations run wild in this dust-ridden ruin. Bring them to heel.",
"name": "Spire of the Watcher: Master",
"icon": "/img/misc/missing_icon_d2.png",
"hasIcon": false
},
"originalDisplayProperties": {
"description": "Machinations run wild in this dust-ridden ruin. Bring them to heel.",
"name": "Spire of the Watcher",
"icon": "/img/misc/missing_icon_d2.png",
"hasIcon": false
},
"selectionScreenDisplayProperties": {
"description": "Masterful, like everything you do. Only the most powerful will not face instant defeat.\n\nMatchmaking: OFF",
"name": "Master",
"hasIcon": false
},
"releaseIcon": "/img/misc/missing_icon_d2.png",
"releaseTime": 0,
"completionUnlockHash": 0,
"activityLightLevel": 0,
"destinationHash": 1615213322,
"placeHash": 2809578934,
"activityTypeHash": 608898761,
"tier": -1,
"pgcrImage": "/img/destiny_content/pgcr/dungeon_spire_of_the_watcher.jpg",
"rewards": [
{
"rewardItems": [
{
"itemHash": 1923658473,
"quantity": 0,
"hasConditionalVisibility": false
}
]
}
],
"modifiers": [
{
"activityModifierHash": 3746163602
},
{
"activityModifierHash": 2833087500
},
{
"activityModifierHash": 2650740350
},
{
"activityModifierHash": 4087563963
},
{
"activityModifierHash": 1783825372
},
{
"activityModifierHash": 1783825372
},
{
"activityModifierHash": 1990363418
},
{
"activityModifierHash": 197794292
},
{
"activityModifierHash": 4226469317
},
{
"activityModifierHash": 1783825372
},
{
"activityModifierHash": 1783825372
},
{
"activityModifierHash": 1783825372
},
{
"activityModifierHash": 1783825372
},
{
"activityModifierHash": 2691200658
},
{
"activityModifierHash": 426976067
},
{
"activityModifierHash": 3196075844
},
{
"activityModifierHash": 795009574
}
],
"isPlaylist": false,
"challenges": [
{
"rewardSiteHash": 0,
"inhibitRewardsUnlockHash": 0,
"objectiveHash": 3211393925,
"dummyRewards": [
{
"itemHash": 73143230,
"quantity": 1,
"hasConditionalVisibility": false
}
]
}
],
"optionalUnlockStrings": [],
"inheritFromFreeRoam": false,
"suppressOtherRewards": false,
"requirements": {
"leaderRequirementLabels": [
{
"displayString": "PlayStation®Plus Required"
},
{
"displayString": "Xbox Live Gold Required"
},
{
"displayString": "PlayStation®Plus Required"
},
{
"displayString": "Xbox Live Gold Required"
}
],
"fireteamRequirementLabels": [
{
"displayString": "Requires Destiny 2: The Witch Queen Dungeon Key"
},
{
"displayString": "Quest progress required. See Ikora Rey in the Tower Bazaar."
},
{
"displayString": "PlayStation®Plus Required"
},
{
"displayString": "Xbox Live Gold Required"
},
{
"displayString": "PlayStation®Plus Required"
},
{
"displayString": "Xbox Live Gold Required"
},
{
"displayString": "Complete step 4 of the \"A Spark of Hope\" quest."
}
]
},
"playlistItems": [],
"matchmaking": {
"isMatchmade": false,
"minParty": 1,
"maxParty": 3,
"maxPlayers": 3,
"requiresGuardianOath": false
},
"directActivityModeHash": 608898761,
"directActivityModeType": 82,
"activityModeHashes": [
608898761,
1164760493
],
"activityModeTypes": [
82,
7
],
"isPvP": false,
"insertionPoints": [
{
"phaseHash": 201188049,
"unlockHash": 0
},
{
"phaseHash": 1483068591,
"unlockHash": 0
},
{
"phaseHash": 2027998024,
"unlockHash": 0
},
{
"phaseHash": 1779644342,
"unlockHash": 0
},
{
"phaseHash": 3603277873,
"unlockHash": 0
},
{
"phaseHash": 3934781543,
"unlockHash": 0
},
{
"phaseHash": 2676434388,
"unlockHash": 0
}
],
"activityLocationMappings": [],
"hash": 2296818662,
"index": 1176,
"redacted": false,
"blacklisted": false
},
"ErrorCode": 1,
"ThrottleSeconds": 0,
"ErrorStatus": "Success",
"Message": "Ok",
"MessageData": {}
}
2 changes: 1 addition & 1 deletion src/test/resources/__files/bungie/milestone-response.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"response":{"3021174356":{"milestoneHash":3021174356,"startDate":null,"endDate":null,"activities":null},"644555645":{"milestoneHash":644555645,"startDate":null,"endDate":null,"activities":null},"3181387331":{"milestoneHash":3181387331,"startDate":1701795600.000000000,"endDate":1702400400.000000000,"activities":[{"activityHash":2122313384,"challengeObjectiveHashes":[]}]},"4253138191":{"milestoneHash":4253138191,"startDate":1701795600.000000000,"endDate":1702400400.000000000,"activities":null},"3603098564":{"milestoneHash":3603098564,"startDate":1701795600.000000000,"endDate":1702400400.000000000,"activities":null},"3802603984":{"milestoneHash":3802603984,"startDate":null,"endDate":null,"activities":null},"2709491520":{"milestoneHash":2709491520,"startDate":null,"endDate":null,"activities":null},"2594202463":{"milestoneHash":2594202463,"startDate":null,"endDate":null,"activities":null},"3899487295":{"milestoneHash":3899487295,"startDate":null,"endDate":null,"activities":null},"2712317338":{"milestoneHash":2712317338,"startDate":1721145600.000000000,"endDate":1721750400.000000000,"activities":[{"activityHash":1042180643,"challengeObjectiveHashes":["2398860795"]}]},"541780856":{"milestoneHash":541780856,"startDate":1701795600.000000000,"endDate":1702400400.000000000,"activities":[{"activityHash":910380154,"challengeObjectiveHashes":[]}]},"526718853":{"milestoneHash":526718853,"startDate":1721145600.000000000,"endDate":1721750400.000000000,"activities":[{"activityHash":1262462921,"challengeObjectiveHashes":["3211393925"]},{"activityHash":2296818662,"challengeObjectiveHashes":["3211393925"]}]}},"errorCode":null}
{"response":{"3021174356":{"milestoneHash":3021174356,"startDate":null,"endDate":null,"activities":null},"644555645":{"milestoneHash":644555645,"startDate":null,"endDate":null,"activities":null},"3181387331":{"milestoneHash":3181387331,"startDate":1701795600.000000000,"endDate":1702400400.000000000,"activities":[{"activityHash":2122313384,"challengeObjectiveHashes":[]}]},"4253138191":{"milestoneHash":4253138191,"startDate":1701795600.000000000,"endDate":1702400400.000000000,"activities":null},"3603098564":{"milestoneHash":3603098564,"startDate":1701795600.000000000,"endDate":1702400400.000000000,"activities":null},"3802603984":{"milestoneHash":3802603984,"startDate":null,"endDate":null,"activities":null},"2709491520":{"milestoneHash":2709491520,"startDate":null,"endDate":null,"activities":null},"2594202463":{"milestoneHash":2594202463,"startDate":null,"endDate":null,"activities":null},"3899487295":{"milestoneHash":3899487295,"startDate":null,"endDate":null,"activities":null},"2712317338":{"milestoneHash":2712317338,"startDate":1721145600.000000000,"endDate":1722355200.000000000,"activities":[{"activityHash":1042180643,"challengeObjectiveHashes":["2398860795"]}]},"541780856":{"milestoneHash":541780856,"startDate":1701795600.000000000,"endDate":1702400400.000000000,"activities":[{"activityHash":910380154,"challengeObjectiveHashes":[]}]},"526718853":{"milestoneHash":526718853,"startDate":1721145600.000000000,"endDate":1722355200.000000000,"activities":[{"activityHash":1262462921,"challengeObjectiveHashes":["3211393925"]},{"activityHash":2296818662,"challengeObjectiveHashes":["3211393925"]}]}},"errorCode":null}

0 comments on commit 1c09f25

Please sign in to comment.