Make the splits weights uint256 #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeSandwich
force-pushed
the
igor/gas
branch
from
9704298 to
4facd52
Compare
CodeSandwich
added a commit
that referenced
this pull request
Feb 28, 2024
CodeSandwich
added a commit
that referenced
this pull request
Feb 28, 2024
CodeSandwich
force-pushed
the
igor/splits_api
branch
from
e87a334 to
24b2f22
Compare
CodeSandwich
force-pushed
the
igor/splits_api
branch
from
24b2f22 to
30be8e4
Compare
xmxanuel
reviewed
Mar 12, 2024
| require(weight != 0, "Splits receiver weight is zero"); | ||
| if (weight > _TOTAL_SPLITS_WEIGHT) weight = _TOTAL_SPLITS_WEIGHT + 1; |
There was a problem hiding this comment.
Okay, just to verify if I understood this correctly.
weight = _TOTAL_SPLITS_WEIGHT + 1;This is a gas optimization. You want to operate with unchecked and still have a the potential overflow protection. Therefore you check if the weight is greater than the _TOTAL_SPLITS_WEIGHT.
You add +1 to ensure it will revert later with totalWeight <= _TOTAL_SPLITS_WEIGHT an additional require would be more expensive.
There was a problem hiding this comment.
Yes, exactly 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the API simpler and more sane, it requires less effort and gas to parse and validate the calldata.