feat(favicon): set cache fields for website icon response

dragonish · Sep 2, 2024 · 8323f05 · 8323f05
1 parent f990d62
commit 8323f05
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/internal/pages/favicon.go b/internal/pages/favicon.go
@@ -8,5 +8,8 @@ import (
 
 // favicon registers favicon routing.
 func favicon(router *gin.Engine) {
-	router.StaticFile("/favicon.ico", model.FAVICON_FILE)
+	router.GET("/favicon.ico", func(ctx *gin.Context) {
+		setCacheHeader(ctx)
+		ctx.File(model.FAVICON_FILE)
+	})
 }
diff --git a/internal/pages/handler.go b/internal/pages/handler.go
@@ -1,10 +1,12 @@
 package pages
 
 import (
+	"net/http"
 	"slender/internal/global"
 	"slender/internal/model"
 	"slender/internal/redirect"
 	"slender/internal/validator"
+	"time"
 
 	"github.com/gin-gonic/gin"
 )
@@ -68,3 +70,11 @@ func adminBypasser(ctx *gin.Context) {
 		return
 	}
 }
+
+// setCacheHeader sets response cache fields.
+//
+// Default is 24 hours.
+func setCacheHeader(c *gin.Context) {
+	c.Header("Cache-Control", "public, max-age=86400")
+	c.Header("Expires", time.Now().Add(24*time.Hour).Format(http.TimeFormat))
+}