chore: add defrag for StringSet #4308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
commented
Dec 13, 2024
| }; | ||
|
|
||
| for (size_t i = 0; i < 10'000; i++) | ||
| ss_->Add(build_str(i)); |
There was a problem hiding this comment.
Would maybe worth to add a unit with ttl to be 100% sure we copy it properly. So two tests in total:
- As is now, without ttl
- With ttl
kostasrim
commented
Dec 13, 2024
| @@ -165,4 +165,44 @@ sds StringSet::MakeSetSds(string_view src, uint32_t ttl_sec) const { | |||
| return sdsnewlen(src.data(), src.size()); | |||
| } | |||
|
|
|||
| // Does not release obj. Callers must deallocate with sdsfree explicitly | |||
| pair<sds, bool> StringSet::DuplicateEntryIfFragmented(void* obj, float ratio) { | |||
There was a problem hiding this comment.
Once I am back from the holidays I will see how to refactor those under one single function for all DenseSet variants. Furthermore, same applies for the tests
|
It can wait for your return, I prefer not to merge it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3822