Fix IC bike SE showing only zeroes #610
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IC bike SE will stop sending notifications if an unsupported Fitness Machine Control Point procedure is used. To prevent it, read the machine fitness features to determine if the Elapsed Time Supported and the Remaining Time Supported bits are set in order to determine if the "Start or Resume" can be used. Also, reduce the connection parameters to 100 instead of 120 to be able to get the notifications which are sent every 500 ms.
|
I appreciate your pull request! Just leaving a message here to let you know that this is important to me, and I will get around to testing it as soon as I can. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IC bike SE will stop sending notifications if an unsupported Fitness Machine Control Point procedure is used. To prevent it, read the machine fitness features to determine if the Elapsed Time Supported and the Remaining Time Supported bits are set in order to determine if the "Start or Resume" can be used.
Also, reduce the connection parameters to 100 instead of 120 to be able to get the notifications which are sent every 500 ms.
This fixes #605