Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continued Extract method cleanup #76577

Merged
merged 23 commits into from
Jan 2, 2025

Simplify

f11598a
Select commit
Loading
Failed to load commit list.
Merged

Continued Extract method cleanup #76577

Simplify
f11598a
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis succeeded Jan 2, 2025 in 0s

.NET Result Analysis

Details

Tip

To unconditionally bypass the build analysis check (turn it green), you can use the escape mechanism feature. The completion time may vary, potentially taking several minutes, depending on the build analysis workload at the moment.

Test Failures (1 tests failed)

🔹 [All failing tests from roslyn-integration-CI]

    Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpWinForms.DeleteControl(VS2022) [Details] [3.07% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configuration

    Data Driven SubResults
      Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpWinForms.DeleteControl (VS2022)
      Exception Message
      System.AggregateException : One or more errors occurred.
      ---- System.NullReferenceException : Object reference not set to an instance of an object.
      Stack Trace
         at Microsoft.CodeAnalysis.ErrorReporting.TestTraceListener.VerifyNoErrorsAndReset() in /_/src/VisualStudio/IntegrationTest/TestSetup/TestTraceListener.cs:line 133
         at Roslyn.VisualStudio.IntegrationTests.AbstractIntegrationTest.<DisposeAsync>d__8.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/AbstractIntegrationTest.cs:line 188
      --- End of stack trace from previous location where exception was thrown ---
         at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
         at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
         at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
      --- End of stack trace from previous location where exception was thrown ---
         at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
         at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      ----- Inner Stack Trace -----
         at Microsoft.VisualStudio.Text.ChangeTagger.Implementation.ChangeSet.Update(ITextVersion currentVersion)
         at Microsoft.VisualStudio.Text.ChangeTagger.Implementation.ChangeSet.Update(ITextVersion currentVersion, ITextVersion desiredVersion)
         at Microsoft.VisualStudio.Text.ChangeTagger.Implementation.ChangeTagger.OnBufferChangedOnBackground(Object sender, TextSnapshotChangedEventArgs e)
         at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.RaiseEvent[TArgs](Object sender, EventHandler`1 eventHandlers, TArgs args)

Was this helpful? Yes No