Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not dismiss extract method when a notification is shown to the user #76549

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Do not dismiss extract method when a notification is shown to the user #76549

merged 1 commit into from
Jan 2, 2025

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #65496

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 22, 2024 04:00
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 22, 2024
@CyrusNajmabadi
Copy link
Member Author

@JoeRobich ptal

@CyrusNajmabadi
Copy link
Member Author

@dotnet/roslyn-ide ptal

ToddGrun
ToddGrun approved these changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit bbbe484 into dotnet:main Jan 2, 2025
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the extractMethodFocus branch January 2, 2025 05:06
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

@JoeRobich JoeRobich Awaiting requested review from JoeRobich

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.

C# Extract Method refactoring failed if "Not all code paths return"
2 participants
@CyrusNajmabadi @ToddGrun