Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update install script source pre-flight updated script #15362

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Update install script source pre-flight updated script #15362

merged 2 commits into from
Dec 22, 2024

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Dec 22, 2024 •
edited by richlander
Loading

@mmitche mmitche enabled auto-merge (squash) December 22, 2024 22:00
baronfel
baronfel approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the caveat that these urls aren't for the signed versions of the scripts - environments that use pwsh with signed scripts only will encounter errors.

@mmitche mmitche merged commit 8589bd2 into dotnet:main Dec 22, 2024
11 checks passed
richlander added a commit that referenced this pull request Dec 27, 2024
@richlander
Revert "Update install script source pre-flight updated script (#15362)"
1496f27 
This reverts commit 8589bd2.
@richlander richlander mentioned this pull request Dec 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmitche @baronfel