Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Metroid Prime GCN and Metroid Prime 2 GCN to be 4:3 #13248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nystrata
Copy link

All of the GameCube versions of Metroid Prime and Metroid Prime 2: [Dark] Echoes only support 4:3, not 16:9.
Currently, Dolphin's widescreen heuristic will fail to detect this and will erratically switch between 4:3 and 16:9 when Aspect Ratio is set to Auto.
These changes prevent the erratic aspect ratio switching by manually declaring that the game is solely 4:3.

To my knowledge, all of the GameCube versions of *Metroid Prime* and *Metroid Prime 2: [Dark] Echoes* only support 4:3, not 16:9 .
Currently, Dolphin's widescreen heuristic will fail to detect this and will erratically switch between 4:3 and 16:9 when Aspect Ratio is set to Auto.
These changes prevent the erratic aspect ratio switching by manually declaring that the game is solely 4:3.
@autofire372
Copy link
Contributor

+1; I've already been forcing this for both games in their User INI files; this also prevents aspect ratio swapping when the games are forced into widescreen, whether via widescreen hack or Gecko/AR codes.

@JMC47
Copy link
Contributor

JMC47 commented Dec 28, 2024

This will break widescreen hacks and such. A better way to fix this would be to use the heuristic overrides to account for the EFB copies that cause this. I attempted this a while ago but apparently I didn't understand how the settings worked properly.

@Nystrata
Copy link
Author

This will break widescreen hacks and such. A better way to fix this would be to use the heuristic overrides to account for the EFB copies that cause this. I attempted this a while ago but apparently I didn't understand how the settings worked properly.

The funny thing is, for the Widescreen Mod for Prime 2, I have to tell people to use SuggestedAspectRatio = 2 anyway since it still erratically switches aspect ratio when using Widescreen Hack

@JMC47
Copy link
Contributor

JMC47 commented Dec 29, 2024

If we fixed the heuristic with better values it may fix both issues.

@Nystrata
Copy link
Author

Ah
I'm not programmer enough to figure that out, so someone else who need to figure that out

Though, would adding the SuggestedAspectRatio in for now be a viable temporary stopgap until the heuristic is improved?
It's been an issue on Dolphin for a long while, and it seems it's unsure when the heuristic can be improved

@JosJuice
Copy link
Member

I'd be willing to set SuggestedAspectRatio = 2 for these two games for now. It's been some time since we made the heuristic values configurable, and yet nobody has contributed working heuristic values for these two games.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants