Save folder memory card header to disk #13231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the memory card won't be recognized as a completely different memory card every game session, which can matter for some save files that use this information as copy protection. This likely works around https://bugs.dolphin-emu.org/issues/12781 for saves created after this change only, though I have not verified this.
AdmiralCurtiss
commented
Dec 22, 2024
| @@ -38,7 +38,7 @@ | |||
| #include "Core/HW/Sram.h" | |||
| #include "Core/NetPlayProto.h" | |||
|
|
|||
| static const char* MC_HDR = "MC_SYSTEM_AREA"; | |||
| static constexpr char HEADER_FILENAME[] = "header.bin"; | |||
There was a problem hiding this comment.
In case you're wondering: I've intentionally not reused what seems to be an old debugging remnant here, because that could potentially lead to an issue with old builds where the memory card size in the header and the actual memory card size mismatch since the old code didn't check for this. (same for the card text encoding)
|
would this mean we could remove the hack from the codebase for F-Zero GX to recognize the memcard as well? |
|
While that would probably work, you'd also be getting rid of the ability to move the save between memory cards. So I would recommend against that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the memory card won't be recognized as a completely different memory card every game session, which can matter for some save files that use this information as copy protection.
This likely works around https://bugs.dolphin-emu.org/issues/12781 for saves created after this change only, though I have not verified this.
This also likely works around that issue where the PSO license file doesn't work on folder memory cards because we don't implement the encryption/checksum for it. I only vaguely remember the details about this and wasn't able to find an issue on our bug tracker, maybe someone knows what I'm talking about so we can verify this...