-
Notifications
You must be signed in to change notification settings - Fork 59
Fix DBALStorage to not ignore exceptions #72
base: master
Are you sure you want to change the base?
Conversation
Requires testing. /cc @EmanueleMinotto |
@enumag you're right, exceptions should be thrown there as well, anyway without tests a merge won't be safe (I'll cover them asap if you can't). |
@EmanueleMinotto I don't have time for that now... Also I've noticed that the DBALStorage completely ignores the Anyway I've duplicated the class to my project for the time being (without the try-catch blocks). |
@enumag yes, I'm reviewing everything in these days |
@EmanueleMinotto I'm also wondering if there should be some sort of support for transactions (when inserting/updateing multiple values). Not sure if that's relevant to other storages than sql database. |
@enumag it would be great if you could open an issue for every thought :) |
Ok, I'll open separate issues. :-) |
All done. You can delete the unrelated commens from this issue if you want. |
@EmanueleMinotto Any progress? |
@enumag not yet, I'm busy with some things + work, I'll take a look asap |
Is there some reason to catch all exceptions? If there is a problem with the storage I want to know about it, not silently ignore it.