Implement receive function to handle received ETH in Ethlance.sol #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implements the TODO in the receive function of the Ethlance.sol contract to handle received ETH. The function constructs _offeredValues from msg.value and calls _createJobWithPassedData with the decoded msg.data. Changes: Implement receive function to handle received ETH. Construct _offeredValues from msg.value. Call _createJobWithPassedData with the decoded msg.data. Impact: This change ensures that the contract correctly handles incoming ETH and creates jobs accordingly, improving the functionality and robustness of the Ethlance platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
implements the TODO in the receive function of the Ethlance.sol contract to handle received ETH. The function constructs _offeredValues from msg.value and calls _createJobWithPassedData with the decoded msg.data.
Changes:
Implement receive function to handle received ETH. Construct _offeredValues from msg.value.
Call _createJobWithPassedData with the decoded msg.data.
Impact:
This change ensures that the contract correctly handles incoming ETH and creates jobs accordingly, improving the functionality and robustness of the Ethlance platform.
Review notes
Testing notes