feat(NewsChannel)!: return followed channel data #8566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
|
I agree with this change. Sadly, this is currently breaking. What we can do in a non-breaking way is add this method to the |
vladfrangu
approved these changes
Sep 11, 2024
almeidx
approved these changes
Oct 2, 2024
Jiralite
changed the title
Jiralite
previously requested changes
Nov 16, 2024
There was a problem hiding this comment.
This should be calling the guild channel manager's method (as noted here: #8566 (comment)) and ideally have the changes made noted here: #8566 (comment). Also, please resolve conflicts!
Syjalo
force-pushed
the
feat/NewsChannel#addFollower()-return-webhook-id
branch
from
6c2beb4 to
522498b
Compare
Syjalo
force-pushed
the
feat/NewsChannel#addFollower()-return-webhook-id
branch
from
0bdea49 to
2ff47d8
Compare
…tps://github.com/Syjalo/discord.js into feat/NewsChannel#addFollower()-return-webhook-id
Syjalo
changed the title
almeidx
reviewed
Dec 11, 2024
almeidx
approved these changes
Jan 4, 2025
almeidx
changed the title
Jiralite
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
GuildChannelManager#addFollowerandAnnouncementChannel#addFollowernow returnFollowedChannelDatainstead of the webhook id.Please describe the changes this PR makes and why it should be merged:
This PR changes the return type of
NewsChannel#addFollower()method to the followed channel.Status and versioning classification: