feat(rest)!: allow passing tokens per request #10682
Open
+72
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckohen
requested review from
vladfrangu,
kyranet,
didinele,
Jiralite and
SpaceEEC
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
github-actions
bot
added
packages:discord.js
packages:rest
packages:proxy
packages:core
labels
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10682 +/- ##
==========================================
+ Coverage 37.96% 37.99% +0.02%
==========================================
Files 239 239
Lines 14877 14889 +12
Branches 1377 1385 +8
==========================================
+ Hits 5648 5657 +9
- Misses 9218 9221 +3
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BREAKING CHANGE: `RequestData.authPrefix` has been removed in favor of `RequestData.auth.prefix`
ckohen
force-pushed
the
refactor/rest/auth-data
branch
from
5453148 to
1bf3ba4
Compare
ckohen
changed the title
vladfrangu
approved these changes
Jan 3, 2025
Jiralite
approved these changes
Jan 3, 2025
Jiralite
requested changes
Jan 3, 2025
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Jiralite
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
RequestData.authPrefixhas been removed in favor ofRequestData.auth.prefixPlease describe the changes this PR makes and why it should be merged:
This allows passing a token when making a request (mostly useful for OAuth endpoints) and moves the token prefix into the same object as it didn't make sense having it separate.
This separates handlers based on the token used to isolate (non-global) ratelimits. There is a chance that ratelimits are hit if a bucket spans tokens. It does respect bucket hashes, so after the first request with each token they will be bucketed together.
Fixes DJS-41
Status and versioning classification: