Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NewsChannel)!: rename NewsChannel to AnnouncementChannel #10532

Merged
merged 7 commits into from
Oct 9, 2024
Merged

refactor(NewsChannel)!: rename NewsChannel to AnnouncementChannel #10532

merged 7 commits into from
Oct 9, 2024

Conversation

imnaiyar
Copy link
Contributor

@imnaiyar imnaiyar commented Oct 3, 2024 •
edited by almeidx
Loading

Please describe the changes this PR makes and why it should be merged:
Renames NewsChannel to AnnouncementChannel to be more in line with API naming (As it was renamed).

Related to:-

I imagine this would be a breaking change

Fixes DJS-57

BREAKING CHANGE: Rename NewsChannel to AnnouncementChannel

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@imnaiyar imnaiyar requested a review from a team as a code owner October 3, 2024 17:24
@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 5:08am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 5:08am

@imnaiyar imnaiyar changed the title refactor(NewsChannel): rename NewsChannel to AnnouncementChannel refactor(NewsChannel)!: rename NewsChannel to AnnouncementChannel Oct 3, 2024
@imnaiyar imnaiyar force-pushed the refactor/news-channel branch from 8c49da6 to 9a3ce13 Compare October 3, 2024 17:34
@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Oct 3, 2024
@Jiralite Jiralite requested a review from almeidx October 9, 2024 09:07
Jiralite
Jiralite approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@almeidx almeidx added the blocked label Oct 9, 2024
didinele
didinele approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@didinele didinele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming nothing was missed, lgtm

@didinele didinele requested a review from vladfrangu October 9, 2024 09:32
@vladfrangu vladfrangu merged commit c8ef899 into discordjs:main Oct 9, 2024
9 checks passed
@almeidx almeidx removed the blocked label Oct 9, 2024
@imnaiyar imnaiyar deleted the refactor/news-channel branch October 14, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didinele didinele didinele approved these changes

@almeidx almeidx almeidx approved these changes

@Jiralite Jiralite Jiralite approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js refactor semver:major
Projects
discord.js
Archived in project
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@imnaiyar @vladfrangu @didinele @Jiralite @almeidx