Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reason of citation with Wikidata #240

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

Futur3r
Copy link
Contributor

@Futur3r Futur3r commented Feb 16, 2023

working on #163

I'm working on implementing the CiTO in the citation editor, the synchronization with wikidata and the visualization of intention of citation in the 'citation' tab, as well as the ability the order citations elements by intention of citation.

@Futur3r
Copy link
Contributor Author

Futur3r commented Feb 16, 2023

For now, the ability to modify citation intentions via the Citation Editor is OK.
But I'm not good with UIs, so the menu is not well positioned. It would be better if it was under the last field (date).

@Futur3r
Copy link
Contributor Author

Futur3r commented Feb 16, 2023

I made the variable 'cito' in wikidata.js so adding new intentions would be as easy as just adding a new pair key:value.
It will be also used to synchronize with Wikidata.

@Futur3r
Copy link
Contributor Author

Futur3r commented Mar 8, 2023

@diegodlh did you planned on implementing citation intentions synchronization in the function syncItemCitationsWithWikidata ?
If so, what were your ideas ?
I'm not sure if I just add loops in the function to check for the difference in the citation intentions between local and remote or the whole function need to be updated with the use of the CitesWorkClaim class, for example ?

I also read the CitesWorkClaim class comments, but I'm not sure how to implement it in the syncItem.. function.

@Futur3r
Copy link
Contributor Author

Futur3r commented Mar 14, 2023

My code is not clean at all, but I put the PR in 'ready for review' to have feedback.

I'm having a hard time with the render of the citations in the citations tab, I'm not too good with CSS.
And I think some part of the code might need to be implemented as methods in objects, but I'm not sure which or how.

It is usable in this state.

@Futur3r Futur3r marked this pull request as ready for review March 14, 2023 20:12
@Dominic-DallOsto
Copy link
Collaborator

Thanks a lot for your work - I'll try and get to reviewing this soon!

@Futur3r
Copy link
Contributor Author

Futur3r commented Mar 26, 2023

While this PR modifies the citations panel and enable supports of qualifiers, it would be important, I think, to implement the property 'series ordinal' (P1545) in the citation panel as well.

So when the citations are ordered by index, their index number would be the value of the 'series ordinal' property in wikidata.
Also, the user could then modify the index of a citation with cita and then synchronize it with Wikidata like the intentions are.

It would be needed to replace the 'up and down arrows' with field in the citation editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants