🐛 Fix registering issuer did #1219

ff137 · 2024-12-05T20:53:06Z

During onboarding, registration of the issuer's DID should be called by the issuer controller, with create_transaction_for_endorser=True. Previously this was being called by the endorser controller, and automatically written to ledger.

🔧 New env var to configure timeout waiting for DID endorsement: ISSUER_DID_ENDORSE_TIMEOUT

Extras in this PR:
✅ Includes full unit test coverage for endorser module (while I was at it)
⚡ The unit test for onboarding issuer no longer requires the 4.5s sleeps

I merged the old, dangling PR #987 into this branch, since the increased load on the endorser now requires increased default timeouts. So, we also add:
🔧 new env var: PUBLISH_REVOCATIONS_TIMEOUT

And while we're at it, made this configurable too:
🔧 CRED_DEF_ACK_TIMEOUT to configure timeout waiting for endorsement of cred defs

Edit:
🚧 Getting some wonky behaviour ...
DID registration and issuer onboarding succeeds, but then trying to create a did-exchange request to that public did fails ... due to not resolving the DIDComm services....

HTTP post `/v1/connections/did-exchange/create-request` failed. Status code: 400. Response: `{"detail":"Failed to resolve DIDComm services from did:sov:Ur2xba9cVQutag8P8moCpZ: Cannot connect via DID that has no associated services. Cannot connect via DID that has no associated services."}`.

despite the raw data on the ledger looking pretty much identical with the new way vs the old way of writing it. 🤷‍♂️

Edit2: Fixed the above... We just need to wait for 2 transactions to be endorsed now, instead of just the 1!
i.e. await did written to ledger before setting as public did, and then await attrib data set before proceeding

Should be called as the issuer, with `create_transaction_for_endorser=True`. Previously was being called as endorser and automatically written to ledger

…while I'm here

… I'm here

… unknown config warning)

…er before setting as public did

…imeout

github-actions · 2024-12-11T16:02:51Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	78	2	97%	119–120
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	35	79%	118–160, 201–205, 360–364, 403–408, 441–445, 473–478, 527–528
app/services/issuer
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 174, 228–229, 256
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	97	5	95%	103–105, 279–284
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	47–55
test_connections.py	141	2	99%	276–277
test_did_exchange.py	73	21	71%	124–187
test_jsonld.py	59	16	73%	134–169
test_proof_request_models.py	24	1	96%	101
test_tenants.py	421	15	96%	203, 247–248, 287, 789, 833–834, 843–844, 853–854, 866–867, 876–877
test_wallet_credentials.py	46	1	98%	57
test_wallet_dids.py	70	10	86%	101–116
test_wallet_jws.py	40	1	98%	56
test_wallet_sd_jws.py	40	1	98%	56
app/tests/e2e/issuer
test_get_records_paginated.py	63	2	97%	65–66
test_save_exchange_record.py	98	1	99%	262
app/tests/e2e/verifier
test_get_records_paginated.py	62	2	97%	59–60
test_many_revocations.py	63	42	33%	31–107, 117–130, 141–216
test_proof_revoked_credential.py	45	12	73%	128–200
test_verifier.py	221	12	95%	654–724
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	141	37	74%	174, 269–349, 362–433
definitions.py	66	26	61%	29–50, 64–65, 94–124, 143–144
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_connections.py	40	8	80%	79–90, 116–127
member_wallets.py	61	15	75%	29–34, 49–54, 69–74, 89–94, 111–118
app/tests/routes/issuer
test_create_offer.py	39	1	97%	145
test_send_credential.py	36	1	97%	125
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	141	2	99%	74, 105
app/tests/services/issuer
test_issuer.py	112	2	98%	282–286
app/tests/util
connections.py	108	35	68%	121–148, 158–186, 213–223, 278–301
ledger.py	50	10	80%	35, 43, 55, 63–67, 77, 83
regression_testing.py	35	17	51%	33, 41–68, 74–81
sse_listener.py	28	4	86%	51–56
trust_registry.py	29	3	90%	24, 27–28
webhooks.py	53	15	72%	19, 65–81, 88–90, 95, 119
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	8	56%	17–33
credentials.py	14	2	86%	13, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
save_exchange_record.py	13	1	92%	29
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	34–35
endorser/tests
test_util_endorsement.py	182	5	97%	290, 295, 354–356
trustregistry
main.py	82	4	95%	46–48, 110
trustregistry/tests
test_main.py	137	1	99%	90
waypoint
main.py	48	1	98%	64
waypoint/services
nats_service.py	109	3	97%	69–71
waypoint/tests/routers
test_waypoint_sse.py	83	5	94%	61–62, 120, 138, 174
waypoint/tests/services
test_nats_service.py	177	9	95%	47, 161, 188, 221, 263, 303, 366, 370, 373
TOTAL	13115	768	94%

Tests	Skipped	Failures	Errors	Time
887	6 💤	0 ❌	0 🔥	3m 38s ⏱️

github-actions · 2024-12-11T16:02:52Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	78	2	97%	119–120
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	61	19	69%	43–49, 79, 110–111, 124–140, 146–149, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	46	72%	118–160, 201–205, 360–364, 403–408, 441–445, 463–478, 484–493, 527–528
app/services/issuer
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 174, 228–229, 256
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	97	5	95%	103–105, 279–284
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	47–55
test_auth.py	66	42	36%	30–41, 51–94, 104–152
test_connections.py	141	2	99%	276–277
test_definitions.py	79	51	35%	33–56, 68–80, 92–106, 118–146, 164–209
test_did_exchange.py	73	21	71%	124–187
test_jsonld.py	59	16	73%	134–169
test_proof_request_models.py	24	1	96%	101
test_revocation.py	118	76	36%	27–77, 90–107, 118–144, 156–181, 193–207, 219–256, 267–293, 305–335, 346–349, 370–376
test_tenants.py	421	364	14%	29–73, 84–117, 128–172, 185–254, 265–316, 329–459, 468–520, 529–565, 574–623, 632–681, 692–734, 746–795, 806–877, 886–993
test_wallet_credentials.py	46	10	78%	79–106
test_wallet_dids.py	70	15	79%	101–116, 128–139
test_wallet_jws.py	40	1	98%	56
test_wallet_sd_jws.py	40	1	98%	56
app/tests/e2e/issuer
test_get_records_paginated.py	63	52	17%	25–161
test_save_exchange_record.py	98	1	99%	262
app/tests/e2e/verifier
test_get_credentials_by_proof_id.py	25	12	52%	27–81
test_get_records_paginated.py	62	49	21%	27–155
test_many_revocations.py	63	42	33%	31–107, 117–130, 141–216
test_proof_revoked_credential.py	45	11	76%	38–114
test_verifier_oob.py	68	22	68%	134–237
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	141	73	48%	131–205, 214–222, 232–254, 288–347, 382–431, 448–510
definitions.py	66	10	85%	41–48, 57–63, 114–121, 134–139
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_async_clients.py	50	2	96%	32–33
member_connections.py	40	4	90%	72, 90, 109, 127
member_wallets.py	61	15	75%	23–27, 43–47, 63–67, 83–87, 103–109
app/tests/routes/issuer
test_create_offer.py	39	1	97%	145
test_send_credential.py	36	1	97%	125
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	141	2	99%	74, 105
app/tests/services/issuer
test_issuer.py	112	2	98%	282–286
app/tests/util
connections.py	108	33	69%	55, 178–186, 201–208, 223, 233–265, 296–301, 315–347
ledger.py	50	26	48%	34–59, 63–67, 73–86
regression_testing.py	35	9	74%	33, 60–68, 74–81
sse_listener.py	28	4	86%	51–56
tenants.py	24	12	50%	10, 16–17, 21–26, 30–35, 39–44, 48–53, 57
trust_registry.py	29	7	76%	20–28
webhooks.py	53	15	72%	19, 65–81, 88–90, 95, 119
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	14	2	86%	13, 18
retry_method.py	36	30	17%	15–36, 68–114
save_exchange_record.py	13	1	92%	29
string.py	15	4	73%	15–16, 20, 24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	21–39
endorser/tests
test_util_endorsement.py	182	5	97%	290, 295, 354–356
trustregistry
main.py	82	4	95%	46–48, 110
trustregistry/tests
test_main.py	137	1	99%	90
TOTAL	12582	1490	88%

Tests	Skipped	Failures	Errors	Time
887	46 💤	0 ❌	0 🔥	5m 34s ⏱️

sonarqubecloud · 2024-12-11T16:46:21Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2024-12-11T16:58:32Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	78	2	97%	119–120
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	35	79%	118–160, 201–205, 360–364, 403–408, 441–445, 473–478, 527–528
app/services/issuer
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 174, 228–229, 256
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	47–55
test_connections.py	141	2	99%	276–277
test_did_exchange.py	73	21	71%	124–187
test_jsonld.py	59	16	73%	134–169
test_proof_request_models.py	24	1	96%	101
test_tenants.py	421	15	96%	203, 247–248, 287, 789, 833–834, 843–844, 853–854, 866–867, 876–877
test_wallet_credentials.py	46	1	98%	57
test_wallet_dids.py	70	10	86%	101–116
test_wallet_jws.py	40	1	98%	56
test_wallet_sd_jws.py	40	1	98%	56
app/tests/e2e/issuer
test_get_records_paginated.py	63	2	97%	65–66
test_save_exchange_record.py	98	1	99%	262
app/tests/e2e/verifier
test_get_records_paginated.py	62	2	97%	59–60
test_many_revocations.py	63	42	33%	31–107, 117–130, 141–216
test_proof_revoked_credential.py	45	12	73%	128–200
test_verifier.py	221	12	95%	654–724
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	141	37	74%	174, 269–349, 362–433
definitions.py	66	26	61%	29–50, 64–65, 94–124, 143–144
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_connections.py	40	8	80%	79–90, 116–127
member_wallets.py	61	15	75%	29–34, 49–54, 69–74, 89–94, 111–118
app/tests/routes/issuer
test_create_offer.py	39	1	97%	145
test_send_credential.py	36	1	97%	125
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	141	2	99%	74, 105
app/tests/services/issuer
test_issuer.py	112	2	98%	282–286
app/tests/util
connections.py	108	35	68%	121–148, 158–186, 213–223, 278–301
ledger.py	50	10	80%	35, 43, 55, 63–67, 77, 83
regression_testing.py	35	17	51%	33, 41–68, 74–81
sse_listener.py	28	4	86%	51–56
trust_registry.py	29	3	90%	24, 27–28
webhooks.py	53	15	72%	19, 65–81, 88–90, 95, 119
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	8	56%	17–33
credentials.py	14	2	86%	13, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
save_exchange_record.py	13	1	92%	29
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	34–35
endorser/tests
test_util_endorsement.py	182	5	97%	290, 295, 354–356
trustregistry
main.py	82	4	95%	46–48, 110
trustregistry/tests
test_main.py	137	1	99%	90
waypoint
main.py	48	1	98%	64
waypoint/services
nats_service.py	109	3	97%	69–71
waypoint/tests/routers
test_waypoint_sse.py	83	5	94%	61–62, 120, 138, 174
waypoint/tests/services
test_nats_service.py	177	9	95%	47, 161, 188, 221, 263, 303, 366, 370, 373
TOTAL	13111	768	94%

Tests	Skipped	Failures	Errors	Time
887	6 💤	0 ❌	0 🔥	3m 40s ⏱️

github-actions · 2024-12-11T16:58:33Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	78	2	97%	119–120
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	61	19	69%	43–49, 79, 110–111, 124–140, 146–149, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	46	72%	118–160, 201–205, 360–364, 403–408, 441–445, 463–478, 484–493, 527–528
app/services/issuer
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 174, 228–229, 256
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	47–55
test_auth.py	66	42	36%	30–41, 51–94, 104–152
test_connections.py	141	2	99%	276–277
test_definitions.py	79	51	35%	33–56, 68–80, 92–106, 118–146, 164–209
test_did_exchange.py	73	21	71%	124–187
test_jsonld.py	59	16	73%	134–169
test_proof_request_models.py	24	1	96%	101
test_revocation.py	118	76	36%	27–77, 90–107, 118–144, 156–181, 193–207, 219–256, 267–293, 305–335, 346–349, 370–376
test_tenants.py	421	364	14%	29–73, 84–117, 128–172, 185–254, 265–316, 329–459, 468–520, 529–565, 574–623, 632–681, 692–734, 746–795, 806–877, 886–993
test_wallet_credentials.py	46	10	78%	79–106
test_wallet_dids.py	70	15	79%	101–116, 128–139
test_wallet_jws.py	40	1	98%	56
test_wallet_sd_jws.py	40	1	98%	56
app/tests/e2e/issuer
test_get_records_paginated.py	63	52	17%	25–161
test_save_exchange_record.py	98	1	99%	262
app/tests/e2e/verifier
test_get_credentials_by_proof_id.py	25	12	52%	27–81
test_get_records_paginated.py	62	49	21%	27–155
test_many_revocations.py	63	42	33%	31–107, 117–130, 141–216
test_proof_revoked_credential.py	45	11	76%	38–114
test_verifier_oob.py	68	22	68%	134–237
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	141	73	48%	131–205, 214–222, 232–254, 288–347, 382–431, 448–510
definitions.py	66	10	85%	41–48, 57–63, 114–121, 134–139
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_async_clients.py	50	2	96%	32–33
member_connections.py	40	4	90%	72, 90, 109, 127
member_wallets.py	61	15	75%	23–27, 43–47, 63–67, 83–87, 103–109
app/tests/routes/issuer
test_create_offer.py	39	1	97%	145
test_send_credential.py	36	1	97%	125
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	141	2	99%	74, 105
app/tests/services/issuer
test_issuer.py	112	2	98%	282–286
app/tests/util
connections.py	108	33	69%	55, 178–186, 201–208, 223, 233–265, 296–301, 315–347
ledger.py	50	26	48%	34–59, 63–67, 73–86
regression_testing.py	35	9	74%	33, 60–68, 74–81
sse_listener.py	28	4	86%	51–56
tenants.py	24	12	50%	10, 16–17, 21–26, 30–35, 39–44, 48–53, 57
trust_registry.py	29	7	76%	20–28
webhooks.py	53	15	72%	19, 65–81, 88–90, 95, 119
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	14	2	86%	13, 18
retry_method.py	36	30	17%	15–36, 68–114
save_exchange_record.py	13	1	92%	29
string.py	15	4	73%	15–16, 20, 24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	21–39
endorser/tests
test_util_endorsement.py	182	5	97%	290, 295, 354–356
trustregistry
main.py	82	4	95%	46–48, 110
trustregistry/tests
test_main.py	137	1	99%	90
TOTAL	12578	1490	88%

Tests	Skipped	Failures	Errors	Time
887	46 💤	0 ❌	0 🔥	5m 41s ⏱️

cl0ete marked this pull request as ready for review December 6, 2024 09:33

cl0ete force-pushed the fix-issuer-did-registration branch from 797132f to fbcc927 Compare December 6, 2024 09:33

cl0ete temporarily deployed to dev December 6, 2024 09:35 — with GitHub Actions Inactive

cl0ete had a problem deploying to dev December 6, 2024 09:38 — with GitHub Actions Failure

ff137 marked this pull request as draft December 6, 2024 20:01

ff137 added 7 commits December 10, 2024 19:14

🐛 Fix registering issuer did

f6d6523

Should be called as the issuer, with `create_transaction_for_endorser=True`. Previously was being called as endorser and automatically written to ledger

🎨

c278c8c

✨ Validate if signature request is applicable for endorsement

b3c33a6

✅ Test coverage for new method

a4c916b

✅ Full test coverage for remaining methods in endorsement_processor, …

39362b4

…while I'm here

✅ Full test coverage for remaining methods in util/endorsement, while…

6c6b856

… I'm here

✅ Full test coverage for main, while I'm here

10fd6a3

ff137 force-pushed the fix-issuer-did-registration branch from fbcc927 to 10fd6a3 Compare December 10, 2024 17:38

ff137 marked this pull request as ready for review December 10, 2024 17:39

ff137 temporarily deployed to dev December 10, 2024 17:41 — with GitHub Actions Inactive

ff137 had a problem deploying to dev December 10, 2024 17:44 — with GitHub Actions Failure

ff137 added 5 commits December 10, 2024 20:23

🔧 Remove asyncio_default_fixture_loop_scope config (again... raises…

db792de

… unknown config warning)

🎨 Rearrange methods, in particular to await did transaction is endors…

508ecca

…er before setting as public did

✅ Fix assertion

7cf8906

🎨 Make delay an argument for the set_endorser_metadata methods

95bc750

✅⚡ Speed up unit tests by overriding sleeps

14420bc

ff137 temporarily deployed to dev December 10, 2024 18:37 — with GitHub Actions Inactive

ff137 self-assigned this Dec 10, 2024

ff137 added bug Something isn't working improvement improving on something that is already existing (not a new feature as such) labels Dec 10, 2024

ff137 requested a review from cl0ete December 10, 2024 18:41

ff137 had a problem deploying to dev December 10, 2024 18:41 — with GitHub Actions Failure

ff137 had a problem deploying to dev December 11, 2024 13:29 — with GitHub Actions Failure

🐛 Endorser should fetch 1 message at a time

47451bf

ff137 temporarily deployed to dev December 11, 2024 15:31 — with GitHub Actions Inactive

ff137 temporarily deployed to dev December 11, 2024 15:35 — with GitHub Actions Inactive

ff137 had a problem deploying to dev December 11, 2024 15:35 — with GitHub Actions Failure

ff137 added 2 commits December 11, 2024 17:48

🔧 Add CRED_DEF_ACK_TIMEOUT env var to configure cred def creation t…

4162cce

…imeout

🔧 Increase default max duration for awaiting webhooks

6567a2e

ff137 temporarily deployed to dev December 11, 2024 15:51 — with GitHub Actions Inactive

ff137 had a problem deploying to dev December 11, 2024 15:55 — with GitHub Actions Failure

ff137 temporarily deployed to dev December 11, 2024 15:55 — with GitHub Actions Inactive

🎨 Clean up constants

96af13b

ff137 temporarily deployed to dev December 11, 2024 16:17 — with GitHub Actions Inactive

ff137 had a problem deploying to dev December 11, 2024 16:21 — with GitHub Actions Failure

ff137 had a problem deploying to dev December 11, 2024 16:31 — with GitHub Actions Failure

ff137 added 2 commits December 11, 2024 18:44

🎨 Increase default timeout

632e299

🎨 Adjust fetch timeout

342347f

ff137 temporarily deployed to dev December 11, 2024 16:46 — with GitHub Actions Inactive

ff137 had a problem deploying to dev December 11, 2024 16:50 — with GitHub Actions Failure

ff137 temporarily deployed to dev December 11, 2024 16:50 — with GitHub Actions Inactive

ff137 temporarily deployed to dev December 11, 2024 16:59 — with GitHub Actions Inactive

ff137 merged commit c649e76 into master Dec 11, 2024
51 checks passed

ff137 deleted the fix-issuer-did-registration branch December 11, 2024 18:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Fix registering issuer did #1219

🐛 Fix registering issuer did #1219

ff137 commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

sonarqubecloud bot commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

🐛 Fix registering issuer did #1219

🐛 Fix registering issuer did #1219

Conversation

ff137 commented Dec 5, 2024 • edited Loading

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

sonarqubecloud bot commented Dec 11, 2024

Quality Gate passed

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

ff137 commented Dec 5, 2024 •

edited

Loading