Api v2 tweaks #622

c8y3 · 2024-10-18T09:08:45Z

finished moving API v2 endpoints into namespace app.blueprints.rest.v2
polished implementation of ioc update (by the way, I avoid retrieve the ioc twice, by changing the signature of the business method iocs_update: it expects an ioc instead of an identifier, see api_v2_ioc_routes)
added backend tests for ioc update
replaced in UI request to /case/ioc/update/{identifier} by API v2
first UI test on the alerts page
fixed: when there was no relationships between users and customers, the administrator could not see any alerts
other code cleanup: removed some dead code, simple quotes

…ier}) into PUT

…dentifier} to respect API v2 rules

…siness layer update method signature

…2/iocs/{identifier}

c8y3 added 25 commits October 15, 2024 16:11

[IMP] Removed unused variable

b66a9a9

[IMP] Moved case /api/v2 endpoints into app.blueprints.rest.v2

b0a0821

[IMP] Removed unused imports

b8546af

[IMP] Removed seemingly dead method

2f0dd16

[IMP] Removed unused imports

1a76c4b

[IMP] Added TODO

24b8121

[IMP] Changed verb of update ioc endpoint (POST /api/v2/iocs/{identif…

a60a5f7

…ier}) into PUT

[IMP] Changed success response format of endpoint PUT /api/v2/iocs/{i…

a32e1d6

…dentifier} to respect API v2 rules

[IMP] Avoid retrieving twice the ioc from database by changing the bu…

4017efa

…siness layer update method signature

[IMP] Added test of error case of PUT /api/v2/iocs/{identifier}

9b7c9c4

[IMP] Removed unused import

d3b9277

[IMP] One import per line

eb09e83

[IMP] Starting to extract post_request_api in its own library

8c56e2f

[IMP] Newly created alert should be visible by administrator

43c6521

[IMP] Added a first end to end test for alerts

63c0cbf

[IMP] Simple quotes

c1d4cd7

[IMP] Added more methods in requests lib

728398e

[IMP] Simple quotes

d8236e2

[IMP] Removed spurious space

4b6ae60

[IMP] Identation

193e833

[IMP] Went a little bit backward

1cfd6a1

[IMP] Spaces

d02282f

[IMP] Removed parameter which was always set to true

7854471

[IMP] Spaces

a011e4b

[IMP] Replaced in ui POST /case/ioc/update/{identifier} by PUT /api/v…

88fee39

…2/iocs/{identifier}

c8y3 requested a review from whikernel October 18, 2024 13:13

c8y3 added enhancement New feature or request quality labels Oct 18, 2024

whikernel merged commit 8dab433 into develop Nov 9, 2024
6 checks passed

whikernel deleted the api_v2_tweaks branch November 9, 2024 17:15

Provide feedback