feat: support new x/posts features
#301
Conversation
dadamu
force-pushed
the
paul/support-new-posts-features
branch
from
1e1eabe to
fb8e6d7
Compare
| @@ -1,35 +0,0 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Removed it since it is unused.
| # Initialize the second contract | ||
| echo "Initializing second contract..." | ||
| echo $KEYRING_PASS | desmos --keyring-backend=file tx wasm instantiate 1 "{}" \ | ||
| --from $USER1 --label "test-contract-" --admin $USER1_ADDRESS --chain-id=testchain -b=sync -y | ||
| echo "Second contract initialized" |
There was a problem hiding this comment.
It is for testing receiver of MsgAcceptPostOwnerTransferRequest and MsgRefusePostOwnerTransferRequest contract, the second contract is used as receiver.
|
The query interaction test errors since missing stargate queries registration: |
| @@ -116,13 +116,16 @@ impl DesmosCli { | |||
| /// Gets a contract address by it's id. | |||
| /// | |||
| /// * `id` - ID of the contract of interest. | |||
| pub fn get_contract_by_code(&self, id: u64) -> String { | |||
| /// * `offset` - Offset of the target contract. | |||
| pub fn get_contract_by_code(&self, id: u64, offset: usize) -> String { | |||
There was a problem hiding this comment.
Add offset parameter for triggering between sender contract and receiver contract.
dadamu
force-pushed
the
paul/support-new-posts-features
branch
from
02e0c40 to
b1d2e94
Compare
| }; | ||
|
|
||
| /// Creates a post inside the given subspace for interaction testing | ||
| pub fn create_test_post(subspace_id: u64, contract_address: &str) -> Post { |
There was a problem hiding this comment.
To make test stateless, we can create a post then return it for the test, then we can avoid from a lot of const number like TEST_MOVABLE_POST and etc.
dadamu
changed the title
x/posts features
dadamu
force-pushed
the
paul/support-new-posts-features
branch
from
b1d2e94 to
554627e
Compare
|
The test will be passed after this PR released desmos-labs/desmos#1218 |
dadamu
force-pushed
the
paul/support-new-posts-features
branch
2 times, most recently
from
ec0e025 to
5defba3
Compare
|
The tests would be passed after desmos-labs/desmos#1226 released. |
dadamu
force-pushed
the
paul/support-new-posts-features
branch
from
79b41d5 to
144cd56
Compare
|
@manu0466 It is ready to review |
Deps: #300Deps #308Deps: #362
This PR intends to support new posts msgs and queries.