Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix - Do not sort imports #326

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Conversation

dshivashankar1994
Copy link
Collaborator

The sort_imports feature introduced has several issues. So do not use it till #287 is sorted

Request: PyInf#12353

The sort_imports feature introduced has several issues. So do not use it till #287 is sorted

Request: PyInf#12353
@dshivashankar1994 dshivashankar1994 merged commit 58bb7f9 into master Apr 8, 2024
14 checks passed
@dshivashankar1994 dshivashankar1994 deleted the dshivashankar1994-patch-1 branch April 8, 2024 04:59
@Carreau
Copy link
Collaborator

Carreau commented Apr 16, 2024

I'm confused, was there an issue with importing sort_import ? #309 should have already deactivated sorting import.

@dshivashankar1994
Copy link
Collaborator Author

Yes, if --no-canonicalize is specified, we were trying to use sort_imports and this commit fixed that

@Carreau
Copy link
Collaborator

Carreau commented Apr 16, 2024

Ah, yes sorry I see the typo now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants