Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #281 #283

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Fixes #281 #283

merged 3 commits into from
Feb 1, 2024

Conversation

Carreau
Copy link
Collaborator

@Carreau Carreau commented Jan 23, 2024

It seem that in 3.11 there is now another FrozenImporter from
_frozen_importlib, I did not manage to get isinstance to work with it so
we need to check with hasattr.

@Carreau Carreau force-pushed the fix-281 branch 2 times, most recently from a49c917 to 5bb363e Compare January 23, 2024 10:50
@Carreau Carreau changed the title Likely fixes #281 Fixes #281 Jan 23, 2024
It seem that in 3.11 there is now another FrozenImporter from
_frozen_importlib, I did not manage to get isinstance to work with it so
we need to check with hasattr.
@dshivashankar1994 dshivashankar1994 merged commit d86dc5b into deshaw:master Feb 1, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants