-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better grouping of imports via isort #263
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aktech
force-pushed
the
imports-grouping
branch
from
September 1, 2023 10:03
3b29ce7
to
b4c9d36
Compare
aktech
force-pushed
the
imports-grouping
branch
from
September 11, 2023 18:24
b4c9d36
to
f6fad7f
Compare
aktech
changed the title
[WIP] Better grouping of imports via isort
Better grouping of imports via isort
Sep 25, 2023
Carreau
approved these changes
Oct 3, 2023
Carreau
added a commit
to Carreau/pyflyby
that referenced
this pull request
Jan 30, 2024
This add some test for what was requested in deshaw#13 and implemented in deshaw#263
Carreau
added a commit
to Carreau/pyflyby
that referenced
this pull request
Apr 8, 2024
This tries to implement some of the rule of import sorting as requested in deshaw#13 using custom logic, This was originally fixed in deshaw#263 using isort, but reverted and re-requested as of deshaw#287
Carreau
added a commit
to Carreau/pyflyby
that referenced
this pull request
Apr 9, 2024
This tries to implement some of the rule of import sorting as requested in deshaw#13 using custom logic, This was originally fixed in deshaw#263 using isort, but reverted and re-requested as of deshaw#287
4 tasks
Carreau
added a commit
to Carreau/pyflyby
that referenced
this pull request
Apr 16, 2024
This tries to implement some of the rule of import sorting as requested in deshaw#13 using custom logic, This was originally fixed in deshaw#263 using isort, but reverted and re-requested as of deshaw#287
Carreau
added a commit
to Carreau/pyflyby
that referenced
this pull request
May 7, 2024
This tries to implement some of the rule of import sorting as requested in deshaw#13 using custom logic, This was originally fixed in deshaw#263 using isort, but reverted and re-requested as of deshaw#287
Carreau
added a commit
to Carreau/pyflyby
that referenced
this pull request
May 7, 2024
This tries to implement some of the rule of import sorting as requested in deshaw#13 using custom logic, This was originally fixed in deshaw#263 using isort, but reverted and re-requested as of deshaw#287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
isort
in the tidy imports logic to improve grouping of imports Fixes #13