Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better grouping of imports via isort #263

Merged
merged 10 commits into from
Oct 3, 2023
Merged

Conversation

aktech
Copy link
Collaborator

@aktech aktech commented Aug 28, 2023

This adds isort in the tidy imports logic to improve grouping of imports Fixes #13

@Carreau Carreau self-requested a review August 29, 2023 16:31
@aktech aktech marked this pull request as draft September 1, 2023 10:02
@aktech aktech changed the title [WIP] Better grouping of imports via isort Better grouping of imports via isort Sep 25, 2023
@aktech aktech marked this pull request as ready for review September 25, 2023 10:18
@Carreau Carreau merged commit 86acd8c into deshaw:master Oct 3, 2023
@aktech aktech deleted the imports-grouping branch October 3, 2023 16:36
Carreau added a commit to Carreau/pyflyby that referenced this pull request Jan 30, 2024
This add some test for what was requested in deshaw#13 and implemented in deshaw#263
Carreau added a commit to Carreau/pyflyby that referenced this pull request Apr 8, 2024
This tries to implement some of the rule of import sorting as requested
in deshaw#13 using custom logic, This was originally fixed in deshaw#263 using isort,
but reverted and  re-requested as of deshaw#287
Carreau added a commit to Carreau/pyflyby that referenced this pull request Apr 9, 2024
This tries to implement some of the rule of import sorting as requested
in deshaw#13 using custom logic, This was originally fixed in deshaw#263 using isort,
but reverted and  re-requested as of deshaw#287
Carreau added a commit to Carreau/pyflyby that referenced this pull request Apr 16, 2024
This tries to implement some of the rule of import sorting as requested
in deshaw#13 using custom logic, This was originally fixed in deshaw#263 using isort,
but reverted and  re-requested as of deshaw#287
Carreau added a commit to Carreau/pyflyby that referenced this pull request May 7, 2024
This tries to implement some of the rule of import sorting as requested
in deshaw#13 using custom logic, This was originally fixed in deshaw#263 using isort,
but reverted and  re-requested as of deshaw#287
Carreau added a commit to Carreau/pyflyby that referenced this pull request May 7, 2024
This tries to implement some of the rule of import sorting as requested
in deshaw#13 using custom logic, This was originally fixed in deshaw#263 using isort,
but reverted and  re-requested as of deshaw#287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better grouping of imports
2 participants