i forgor undefined 💀 #392
Closed
i forgor undefined 💀 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new `replace` command. * Update existing `rem` command to direct users to `replace` when attempting to overwrite an existing key. * Update docs to reflect current commands.
Isn't test driven development fun? oobps
randomPoison
force-pushed
the
forgor-undefined
branch
from
ca31ca5 to
5628ecc
Compare
|
Okay given the convo I had with @sshirokov in #a it sounds like this wouldn't land for a while anyway, so i'm dropping it in favor of merging the fix into #384 (which also won't land for a while lol). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
.forgetto forget a memory that doesn't exist, the current message is... not ideal:This PR updates the message to one that more directly calls out that they key doesn't exist, which should help people realize when they typed in the wrong key name.