Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storageclasses view keeps the same output as kubectl get sc #2132

Merged
merged 3 commits into from
Nov 12, 2023

Conversation

wjiec
Copy link
Contributor

@wjiec wjiec commented Jun 15, 2023

This adds the "default" marks to the name of the storageclasses, for ease of preview. Add same fields to the view to suggest some useful information(same as kubectl get sc output).

@wjiec wjiec closed this Oct 18, 2023
@derailed derailed reopened this Oct 18, 2023
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjiec Nice work! Thank you for this PR Jayson!!
I've reopened since this is indeed needed to align with kubectl (sorry for the delay!)

internal/render/sc.go Show resolved Hide resolved
internal/render/sc_test.go Show resolved Hide resolved
@wjiec wjiec force-pushed the feat/storageclasses-view branch from b3cfd6a to c8dcbde Compare October 19, 2023 05:11
@wjiec wjiec force-pushed the feat/storageclasses-view branch from c8dcbde to cbd0591 Compare October 19, 2023 05:18
@wjiec wjiec requested a review from derailed October 19, 2023 05:21
@wjiec
Copy link
Contributor Author

wjiec commented Oct 19, 2023

I've finished my changes, take a look when you have time 😃

Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjiec Thank you for the updates Jayson!

@derailed derailed merged commit 46a1ed0 into derailed:master Nov 12, 2023
1 check passed
rm-hull added a commit to rm-hull/k9s that referenced this pull request Nov 12, 2023
* 'master' of github.com:derailed/k9s: (130 commits)
  added flux suspended resources retrieval plugin (derailed#1584)
  Provide white blur so images work in dark modes (derailed#1597)
  Add context to get-all (derailed#1701)
  fix brew command in the readme (derailed#2012)
  Add support for using custom kubeconfig with log_full plugin (derailed#2014)
  feat: allow for multiple plugin files in $XDG_DATA_DIRS/k9s/plugins (derailed#2029)
  Clean up issues introduced by derailed#2125 (derailed#2289)
  Pod view resembles more the output of kubectl get pods -o wide (derailed#2125)
  Update README.md with snap install (derailed#2262)
  Add snapcraft config (derailed#2123)
  storageclasses view keeps the same output as kubectl get sc (derailed#2132)
  Fix merge issues with PR derailed#2168 (derailed#2288)
  Add colour config for container picker (derailed#2140)
  Add env var to disable node pod counts (derailed#2168)
  Use current k9s NS if new context has no default NS (derailed#2197)
  Bump actions/setup-go from 4.0.1 to 4.1.0 (derailed#2200)
  fix: trigger a single log refresh after changing 'since' (derailed#2202)
  Add crossplane plugin (derailed#2204)
  fix(derailed#1359): add option to keep missing clusters in config (derailed#2213)
  K9s release v0.28.2
  ...
@wjiec wjiec deleted the feat/storageclasses-view branch November 13, 2023 01:31
thejoeejoee pushed a commit to thejoeejoee/k9s that referenced this pull request Feb 23, 2024
…#2132)

* storageclasses view keeps the same output as kubectl get sc

* fix sc test

* rollback labels and valid field and add test case
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this pull request Apr 3, 2024
…#2132)

* storageclasses view keeps the same output as kubectl get sc

* fix sc test

* rollback labels and valid field and add test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants