Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aedp_vadx feature toggle for experimental work safeguard #33218

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

adamwhitlock1
Copy link
Contributor

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • adds a toggle for work on the Authenticated Experience Design Patterns prototype app
  • toggle not used yet, but will be in a future PR to add some tooling for the team
  • toggle will be exclusively used by this team for non-production work around design patterns

Related issue(s)

Testing done

  • verified that feature toggle is available locally and through mock server for aedp mock app

Screenshots

No UI changes just adding toggle

What areas of the site does it impact?

AEDP mock form, but really nothing impacted yet

Acceptance criteria

  • toggle added

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@adamwhitlock1 adamwhitlock1 requested review from a team as code owners November 25, 2024 18:32
bellepx0
bellepx0 previously approved these changes Nov 25, 2024
Copy link
Contributor

@bellepx0 bellepx0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

rsmithadhoc
rsmithadhoc previously approved these changes Nov 26, 2024
@adamwhitlock1
Copy link
Contributor Author

@rsmithadhoc and @bellepx0 when yall have a moment, could you re-approve. I found an issue with the casing of the toggle, so had to fix that so that it would behave correctly. Thanks!

@adamwhitlock1 adamwhitlock1 merged commit 7e5c281 into main Nov 27, 2024
76 checks passed
@adamwhitlock1 adamwhitlock1 deleted the aedp/aw/196/vadx-discovery-add-toggle branch November 27, 2024 16:35
Khoa-V-Nguyen pushed a commit that referenced this pull request Dec 16, 2024
* add aedp_vadx feature toggle for experimental work safeguard

* fix camel casing resulting in lowercase by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants