Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#179] Update Task Blue (10182 form) to match new designs #32775

Merged
merged 11 commits into from
Oct 30, 2024

Conversation

bellepx0
Copy link
Contributor

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Updated content in prefill alerts to match new designs
  • Updated need help sections
  • Deleted home phone number card on Veteran Information page to match designs
  • On edit mailing address page, fixed the functionality of the "Do you also want to update this info in your VA.gov profile" question to eradicate the default value "yes".

Related issue(s)

#179

Testing done

Tests pass locally.

Screenshots

Screenshot 2024-10-29 at 11 16 04 AM

Screenshot 2024-10-29 at 11 16 21 AM

Screenshot 2024-10-29 at 11 16 37 AM

Screenshot 2024-10-29 at 11 18 31 AM

Screenshot 2024-10-29 at 11 19 38 AM

Screenshot 2024-10-29 at 11 20 12 AM

What areas of the site does it impact?

N/A

Acceptance criteria

  • Task blue works as expected according to Figma designs flow.
  • Designs match as expected.

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@bellepx0 bellepx0 requested review from a team as code owners October 29, 2024 18:21
Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon found

Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.

What you can do

Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.

Note:

Font Awesome is deprecated. Please use va-icon instead. For more information, visit the migration documentation: Migrate from font awesome to va-icon

// >
// <span>
// <strong>{editText}</strong>
// <va-icon

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon found

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason for commenting these out? can we just delete?

@va-vfs-bot va-vfs-bot temporarily deployed to master/bp-179-update-task-blue/main October 29, 2024 18:47 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/bp-179-update-task-blue/main October 29, 2024 21:15 Inactive
adamwhitlock1
adamwhitlock1 previously approved these changes Oct 30, 2024
Copy link
Contributor

@adamwhitlock1 adamwhitlock1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully once the unit tests issue is resolved we can update with main and get this merged.

// >
// <span>
// <strong>{editText}</strong>
// <va-icon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason for commenting these out? can we just delete?

adamwhitlock1
adamwhitlock1 previously approved these changes Oct 30, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/bp-179-update-task-blue/main October 30, 2024 15:06 Inactive
Copy link
Contributor

@adamwhitlock1 adamwhitlock1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bellepx0 bellepx0 merged commit de41e38 into main Oct 30, 2024
69 of 70 checks passed
@bellepx0 bellepx0 deleted the bp-179-update-task-blue branch October 30, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants