Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authed patterns/aw/159/update prefill add 22 1990 form task gray #32364

Conversation

adamwhitlock1
Copy link
Contributor

@adamwhitlock1 adamwhitlock1 commented Oct 10, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Adds the 22-1990 form as a prototype form to be used in the authenticated patterns design team work.
  • We will be adding further changes to this form after the main foundation is set, so this main PR is to get the form rendering and get the prefill data working on the mock server for this form
  • Authenticated Experience Design Patterns team
  • No flipper in user, but this form will not be published to prod and is only for research session usage through Codespaces
  • Removed other tasks other than gray and orange for now, since those are the ones that have been started for pattern 2

Related issue(s)

Testing done

  • Tested with prefill
  • Verified that form shows up at /mock-form-ae-design-patterns/2/task-orange
  • Updated unit test for tabs

Screenshots

Intro page:
Screenshot 2024-10-11 at 7 29 14 AM

First page with prefilled info
Screenshot 2024-10-11 at 7 29 56 AM

Military info with prefill
Screenshot 2024-10-11 at 7 30 18 AM

What areas of the site does it impact?

mock form, no prod impact

Acceptance criteria

  • Form appears and prefill data is available to form
  • Form is ready for further modifications for research study specifics

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/authed-patterns/aw/159/update-prefill-add-22-1990-form-task-gray/main October 10, 2024 21:41 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/authed-patterns/aw/159/update-prefill-add-22-1990-form-task-gray/main October 11, 2024 13:30 Inactive
@adamwhitlock1 adamwhitlock1 marked this pull request as ready for review October 11, 2024 13:33
@adamwhitlock1 adamwhitlock1 requested review from a team as code owners October 11, 2024 13:33
Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon found

Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.

What you can do

Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.

Note:

Font Awesome is deprecated. Please use va-icon instead. For more information, visit the migration documentation: Migrate from font awesome to va-icon

aria-live="polite"
>
<div className="vads-u-flex--1 vads-u-margin-top--2p5 vads-u-margin-x--2 ">
<va-icon icon="info" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon found

Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

id="collapsiblePanel"
className="usa-accordion-bordered screen-only"
>
{/* eslint-disable-next-line jsx-a11y/no-redundant-roles */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

@@ -0,0 +1,490 @@
// disabled for unit testing to work
/* eslint-disable no-restricted-syntax */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

@@ -0,0 +1,490 @@
// disabled for unit testing to work
/* eslint-disable no-restricted-syntax */
/* eslint-disable guard-for-in */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

@va-vfs-bot va-vfs-bot temporarily deployed to master/authed-patterns/aw/159/update-prefill-add-22-1990-form-task-gray/main October 11, 2024 13:42 Inactive
Copy link
Contributor

@bellepx0 bellepx0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and confirming prefill works as expected. Also ran the unit tests as well. Approved!

@adamwhitlock1 adamwhitlock1 merged commit 1194608 into main Oct 11, 2024
69 of 70 checks passed
@adamwhitlock1 adamwhitlock1 deleted the authed-patterns/aw/159/update-prefill-add-22-1990-form-task-gray branch October 11, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants