VACMS-19888 Remove email signup widget feature toggle

[randimays]

Description

We have successfully implemented a new React widget for the email signup form to replace the old form in content-build. This means we will no longer need the CMS feature toggle.

Related ticket: #19888
PR that removed the code usage: department-of-veterans-affairs/content-build#2404

The FEATURE_EMAIL_UPDATE_WIDGET feature toggle is currently off in staging and production CMS:

Staging

Production

[github-actions]

Checking composer.lock changes...

[eselkin]

LGTM.

[chriskim2311]

LGTM

[github-actions]

Checking composer.lock changes...

[jilladams]

How do we feel about the test failures here? It seems very noisy, and I can't find the Cypress output but if it's totally unrelated to the code change, we could advocate for overriding branch protections to get it merged. That may be a controversial idea? @omahane what do you think? (Randi's doing a CMS solid to remove this toggle, and it keeps failing weird php unit / cypress tests.)

[dsasser]

How do we feel about the test failures here? It seems very noisy, and I can't find the Cypress output but if it's totally unrelated to the code change, we could advocate for overriding branch protections to get it merged. That may be a controversial idea? @omahane what do you think? (Randi's doing a CMS solid to remove this toggle, and it keeps failing weird php unit / cypress tests.)

Let's get test passing on this so we don't have to bypass merge restrictions. If getting tests to pass on TB, that should be passing, is challenging or impossible, that is something we need to escalate to the CMS team. As it stands now, the TB was in a failed state for k8s image reasons, so I'm rebuilding the TB, which will cause tests to re-trigger once it comes back online.

[github-actions]

Checking composer.lock changes...

[va-cms-bot]

Cypress Accessibility Violations

/test-data-repudiandae

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.4.1.2, ACT
Description: Ensure buttons have discernible text
Help: Buttons must have discernible text
Nodes:

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
  Impact: critical
  Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: button[data-proofing-help-title="About 'Main content' field"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"